node
node copied to clipboard
nodejs
sqlite: add build option to build without sqlite
Distributors of Node.js may want to ship without all of surface area so in some cases build time options are provided to to that.
I was asked by the RHEL team to add an option to build without sqlite so that have that flexibility and this PR does that.
Review requested:
- [ ] @nodejs/config
- [ ] @nodejs/gyp
- [ ] @nodejs/security-wg
- [ ] @nodejs/sqlite
- [ ] @nodejs/startup
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.14%. Comparing base (
53abd1a) to head (65e8818). Report is 109 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #58122 +/- ##
==========================================
- Coverage 90.20% 90.14% -0.07%
==========================================
Files 630 630
Lines 186391 186784 +393
Branches 36612 36651 +39
==========================================
+ Hits 168134 168369 +235
- Misses 11068 11199 +131
- Partials 7189 7216 +27
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/node_binding.cc | 82.67% <ø> (ø) |
|
| src/node_builtins.cc | 79.17% <100.00%> (-0.49%) |
:arrow_down: |
| src/node_metadata.cc | 91.52% <ø> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@anonrig addressed all of your comments except the one I asked for clarification on .