node icon indicating copy to clipboard operation
node copied to clipboard

[v22.x backport] deps: V8: backport e5dbbbadcbff

Open RaisinTen opened this issue 8 months ago • 6 comments

Manual backport for v22.x of the changes in https://github.com/nodejs/node/pull/58010 which has been closed in favor of the V8 upgrade https://github.com/nodejs/node/pull/58070 which already contains this change.

Original commit message:

Enable --perf-prof flag on MacOS

MacOS actually can share the implementation of {PerfJitLogger} with
Linux. From the issue 40112126, only Fuzzer tests on Windows ran
into UNREACHABLE/FATAL because of the unimplemented {PerfJitLogger}.
This CL enables the flag --perf-prof on MacOS.

Bug: 403765219
Change-Id: I97871fbcc0cb9890c51ca14fd7a6e65bd0e3c0d2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6385655
Reviewed-by: Clemens Backes <[email protected]>
Reviewed-by: Matthias Liedtke <[email protected]>
Auto-Submit: 杨文明 <[email protected]>
Commit-Queue: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#99885}

Refs: https://github.com/v8/v8/commit/e5dbbbadcbff64d4d6031e0288278aacd67eb904

cc @targos @tmm1

RaisinTen avatar May 02 '25 11:05 RaisinTen

Review requested:

  • [ ] @nodejs/gyp
  • [ ] @nodejs/security-wg
  • [ ] @nodejs/v8-update

nodejs-github-bot avatar May 02 '25 11:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66541/

nodejs-github-bot avatar May 02 '25 11:05 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6525/

nodejs-github-bot avatar May 02 '25 11:05 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6525/

nodejs-github-bot avatar May 02 '25 12:05 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6525/

nodejs-github-bot avatar May 02 '25 12:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66555/

nodejs-github-bot avatar May 03 '25 04:05 nodejs-github-bot

Landed in e0a025ae7f25c03d7cd17c3b1b1c9ed3281e0a21

aduh95 avatar May 06 '25 20:05 aduh95

Sorry, which size_t to int change are you referring to?

RaisinTen avatar May 07 '25 08:05 RaisinTen