crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL

Open codebytere opened this issue 8 months ago • 3 comments

OPENSSL_TLS_SECURITY_LEVEL isn't defined at all in BoringSSL and will cause compilation failures.

Ref https://github.com/nodejs/node/pull/57323 Ref https://github.com/nodejs/node/pull/56601

See boringssl search results

May 01 '25 17:05 codebytere

Review requested:

[ ] @nodejs/crypto
[ ] @nodejs/security-wg

May 01 '25 17:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66544/

May 02 '25 13:05 nodejs-github-bot

FWIW, the default value is only 1 for OpenSSL < 3.2. On systems that compile and link against OpenSSL >= 3.2, the default value is already 2. That being said, I assume BoringSSL is still targeting OpenSSL 1.0.2/1.1.0/1.1.1 instead of 3.x, so assuming the pre-3.2 default seems reasonable.

May 02 '25 22:05 tniessen

CI: https://ci.nodejs.org/job/node-test-pull-request/66621/

May 05 '25 17:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66766/

May 12 '25 04:05 nodejs-github-bot

Landed in f56590e161ca6d2eeda13339af6fc981fce0fd68

May 12 '25 12:05 nodejs-github-bot

This does not land cleanly on v22.x-staging

Jun 10 '25 14:06 aduh95