node icon indicating copy to clipboard operation
node copied to clipboard
verified publisher icon nodejs

build: use FILE_OFFSET_BITS=64 even on 32-bit arch

Open RafaelGSS opened this issue 8 months ago • 4 comments

Refs: https://github.com/nodejs/node/issues/57934

RafaelGSS avatar Apr 30 '25 20:04 RafaelGSS

Review requested:

  • [ ] @nodejs/gyp

nodejs-github-bot avatar Apr 30 '25 20:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66520/

nodejs-github-bot avatar Apr 30 '25 22:04 nodejs-github-bot

s/even on/esp. on/ - on 64 bits architectures the define is a no-op because off_t is already 64 bits.

bnoordhuis avatar May 01 '25 07:05 bnoordhuis

CI: https://ci.nodejs.org/job/node-test-pull-request/66523/

nodejs-github-bot avatar May 01 '25 08:05 nodejs-github-bot

CI was green. Landing it manually as I had to update commit title.

RafaelGSS avatar May 06 '25 18:05 RafaelGSS

Landed in 74c8358fa71d

RafaelGSS avatar May 06 '25 18:05 RafaelGSS