node icon indicating copy to clipboard operation
node copied to clipboard

src: use ranges library (C++20) more systematically

Open lemire opened this issue 8 months ago β€’ 3 comments

In PR https://github.com/nodejs/node/pull/57975, I introduced C++20 ranges as an experiment. This current PR extends the application of ranges to simplify even more code.

lemire avatar Apr 25 '25 18:04 lemire

Review requested:

  • [ ] @nodejs/config
  • [ ] @nodejs/crypto
  • [ ] @nodejs/http2
  • [ ] @nodejs/net
  • [ ] @nodejs/single-executable
  • [ ] @nodejs/startup

nodejs-github-bot avatar Apr 25 '25 18:04 nodejs-github-bot

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (25fe802) to head (0a1606a). Report is 495 commits behind head on main.

Files with missing lines Patch % Lines
src/inspector_socket.cc 0.00% 0 Missing and 1 partial :warning:
src/node.cc 85.71% 0 Missing and 1 partial :warning:
src/node_credentials.cc 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58028   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files         630      630           
  Lines      186159   186147   -12     
  Branches    36473    36474    +1     
=======================================
- Hits       168053   168050    -3     
- Misses      10976    10977    +1     
+ Partials     7130     7120   -10     
Files with missing lines Coverage Ξ”
src/cleanup_queue.cc 85.00% <100.00%> (-0.72%) :arrow_down:
src/crypto/crypto_util.cc 72.26% <100.00%> (+0.25%) :arrow_up:
src/inspector_socket_server.cc 85.32% <100.00%> (ΓΈ)
src/node_dotenv.cc 84.53% <100.00%> (ΓΈ)
src/node_http2.h 91.61% <100.00%> (-0.05%) :arrow_down:
src/node_messaging.cc 82.62% <100.00%> (+0.13%) :arrow_up:
src/node_platform.cc 88.67% <100.00%> (-0.03%) :arrow_down:
src/node_process_object.cc 86.17% <100.00%> (-0.12%) :arrow_down:
src/node_report.cc 93.22% <100.00%> (-0.02%) :arrow_down:
src/node_sea.cc 91.28% <100.00%> (-0.03%) :arrow_down:
... and 5 more

... and 20 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 25 '25 19:04 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66462/

nodejs-github-bot avatar Apr 25 '25 19:04 nodejs-github-bot

Landed in 2e9e844d99d7880099736829f1c19b939a2436e3

nodejs-github-bot avatar Jun 26 '25 02:06 nodejs-github-bot