src: improve error handling in exceptions.cc

[jasnell]

Replace ToLocalChecked() and Check() uses in exception.cc

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 38.54167% with 59 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (9eb9c26) to head (6296173). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_file.cc	30.95%	27 Missing and 2 partials :warning:
src/api/exceptions.cc	39.02%	12 Missing and 13 partials :warning:
src/env-inl.h	66.66%	2 Missing and 2 partials :warning:
src/node_process_methods.cc	0.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57954      +/-   ##
==========================================
- Coverage   90.23%   90.20%   -0.04%     
==========================================
  Files         633      633              
  Lines      186871   186923      +52     
  Branches    36687    36709      +22     
==========================================
- Hits       168626   168608      -18     
- Misses      11046    11086      +40     
- Partials     7199     7229      +30     

Files with missing lines	Coverage Δ
src/node.h	92.30% <ø> (ø)
src/node_process_methods.cc	87.85% <0.00%> (ø)
src/env-inl.h	93.02% <66.66%> (-1.18%)	:arrow_down:
src/api/exceptions.cc	69.38% <39.02%> (-24.80%)	:arrow_down:
src/node_file.cc	76.17% <30.95%> (-0.77%)	:arrow_down:

... and 39 files with indirect coverage changes

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66420/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66483/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66667/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66670/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66671/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66681/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66765/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66812/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66893/

[jasnell]

You're killing me here flaky CI.... sigh

[jasnell]

No idea if it's flaky failures or failures related to this changeset. Will close for now and revisit later.