node icon indicating copy to clipboard operation
node copied to clipboard

fs: add signal option to fs.stat()

Open mertcanaltin opened this issue 8 months ago • 12 comments

add signal option to fs.stat() for #57751

mertcanaltin avatar Apr 06 '25 19:04 mertcanaltin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.22%. Comparing base (d89657c) to head (7c66528). Report is 252 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57775      +/-   ##
==========================================
- Coverage   90.24%   90.22%   -0.02%     
==========================================
  Files         635      635              
  Lines      187588   187596       +8     
  Branches    36860    36858       -2     
==========================================
- Hits       169292   169266      -26     
- Misses      11060    11111      +51     
+ Partials     7236     7219      -17     
Files with missing lines Coverage Δ
lib/fs.js 98.27% <100.00%> (+<0.01%) :arrow_up:

... and 27 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 06 '25 20:04 codecov[bot]

The commit message after subsystem should start with imperative verb and probably be more specific, maybe something like fs: add signal option to fs.stat()?

thank you very much, I will be more careful with this, sometimes I make the wrong sentence 🙏

mertcanaltin avatar Apr 06 '25 21:04 mertcanaltin

CI: https://ci.nodejs.org/job/node-test-pull-request/66196/

nodejs-github-bot avatar Apr 11 '25 13:04 nodejs-github-bot

@mertcanaltin ... can you please remove the merge commit from this and use rebase instead to catch it up?

jasnell avatar Apr 13 '25 16:04 jasnell

@mertcanaltin ... can you please remove the merge commit from this and use rebase instead to catch it up?

thank you I used rebase

mertcanaltin avatar Apr 13 '25 17:04 mertcanaltin

CI: https://ci.nodejs.org/job/node-test-pull-request/66241/

nodejs-github-bot avatar Apr 13 '25 17:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66264/

nodejs-github-bot avatar Apr 14 '25 16:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66331/

nodejs-github-bot avatar Apr 17 '25 13:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66366/ 💛

nodejs-github-bot avatar Apr 19 '25 15:04 nodejs-github-bot

@BridgeAR I looked at this benchmark, but the benchmark result fails. Can you restart this benchmark line?

mertcanaltin avatar May 21 '25 19:05 mertcanaltin

On the question of whether we really want to support this, I'm fine in general with the change but I also don't see it as being all that useful given the additional complexity.

jasnell avatar May 22 '25 22:05 jasnell

hello I tried to fix the complex structure

mertcanaltin avatar Jun 01 '25 22:06 mertcanaltin