fs: add signal option to fs.stat()
add signal option to fs.stat() for #57751
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.22%. Comparing base (
d89657c) to head (7c66528). Report is 252 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #57775 +/- ##
==========================================
- Coverage 90.24% 90.22% -0.02%
==========================================
Files 635 635
Lines 187588 187596 +8
Branches 36860 36858 -2
==========================================
- Hits 169292 169266 -26
- Misses 11060 11111 +51
+ Partials 7236 7219 -17
| Files with missing lines | Coverage Δ | |
|---|---|---|
| lib/fs.js | 98.27% <100.00%> (+<0.01%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
The commit message after subsystem should start with imperative verb and probably be more specific, maybe something like
fs: add signal option to fs.stat()?
thank you very much, I will be more careful with this, sometimes I make the wrong sentence 🙏
CI: https://ci.nodejs.org/job/node-test-pull-request/66196/
@mertcanaltin ... can you please remove the merge commit from this and use rebase instead to catch it up?
@mertcanaltin ... can you please remove the merge commit from this and use rebase instead to catch it up?
thank you I used rebase
CI: https://ci.nodejs.org/job/node-test-pull-request/66241/
CI: https://ci.nodejs.org/job/node-test-pull-request/66264/
CI: https://ci.nodejs.org/job/node-test-pull-request/66331/
CI: https://ci.nodejs.org/job/node-test-pull-request/66366/ 💛
@BridgeAR I looked at this benchmark, but the benchmark result fails. Can you restart this benchmark line?
On the question of whether we really want to support this, I'm fine in general with the change but I also don't see it as being all that useful given the additional complexity.
hello I tried to fix the complex structure