node
node copied to clipboard
nodejs
src: add a variant of ToV8Value()
Adds a variant of ToV8Value for array of primitives that do not need to throw during conversion - there is essentially no exceptions that can be thrown then you create an array of integers and you are only dealing with the one-size-fit-all abstraction of ToV8Value.
Codecov Report
Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
Project coverage is 90.24%. Comparing base (
922ce9d) to head (d037058). Report is 411 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/util-inl.h | 86.66% | 0 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #57576 +/- ##
========================================
Coverage 90.23% 90.24%
========================================
Files 629 630 +1
Lines 184939 185080 +141
Branches 36232 36229 -3
========================================
+ Hits 166885 167020 +135
- Misses 11011 11031 +20
+ Partials 7043 7029 -14
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/node_v8.cc | 81.72% <100.00%> (+1.00%) |
:arrow_up: |
| src/util-inl.h | 84.39% <86.66%> (+1.12%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@anonrig Are you still blocking the PR? It's updated significantly and the helper is being used in a function.
