node icon indicating copy to clipboard operation
node copied to clipboard

test: update WPT for url to 6fa3fe8a92

Open nodejs-github-bot opened this issue 1 year ago • 4 comments

This is an automated update of the WPT for url to https://github.com/web-platform-tests/wpt/commit/6fa3fe8a929be45422cd46a8961e647e13d0cab8.

nodejs-github-bot avatar Dec 05 '24 00:12 nodejs-github-bot

Review requested:

  • [ ] @nodejs/web-standards

nodejs-github-bot avatar Dec 05 '24 00:12 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.50%. Comparing base (ac7fea6) to head (516ec93). Report is 1340 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56136      +/-   ##
==========================================
+ Coverage   88.01%   88.50%   +0.49%     
==========================================
  Files         656      656              
  Lines      189136   189261     +125     
  Branches    36004    36346     +342     
==========================================
+ Hits       166461   167511    +1050     
+ Misses      15842    14966     -876     
+ Partials     6833     6784      -49     

see 95 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 05 '24 01:12 codecov[bot]

URL specification recently changed to Unicode 15.1 where the new tests are only passing for 2 browsers/runtimes. Ada isn't one of them yet. WHATWG plans to update Unicode to 16 on February. I'm not sure if it's worth fixing this now, and do a larger update on February.

cc @nodejs/tsc for visibility

anonrig avatar Dec 05 '24 15:12 anonrig

/cc @nodejs/web-standards

aduh95 avatar Dec 05 '24 16:12 aduh95

It looks like some of our own tests uses WPT fixtures and are therefor impacted

aduh95 avatar Dec 08 '24 12:12 aduh95

It looks like some of our own tests uses WPT fixtures and are therefor impacted

Yes, I think we should remove it. That test depends on ada to_ascii and to_unicode functions but we already test it inside the URL parser. There is no need to have an additional test specifically for it.

anonrig avatar Dec 08 '24 16:12 anonrig

CI: https://ci.nodejs.org/job/node-test-pull-request/63953/

nodejs-github-bot avatar Dec 09 '24 13:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63962/

nodejs-github-bot avatar Dec 09 '24 18:12 nodejs-github-bot

Landed in 7443a28c28826518998b5a732644d752a7032433

nodejs-github-bot avatar Dec 10 '24 00:12 nodejs-github-bot