node icon indicating copy to clipboard operation
node copied to clipboard

src: fix outdated js2c.cc references

Open legendecas opened this issue 1 year ago β€’ 3 comments

legendecas avatar Dec 04 '24 21:12 legendecas

Review requested:

  • [ ] @nodejs/startup

nodejs-github-bot avatar Dec 04 '24 21:12 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.98%. Comparing base (3bb1d28) to head (028180a). Report is 109 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56133      +/-   ##
==========================================
+ Coverage   87.95%   87.98%   +0.03%     
==========================================
  Files         656      656              
  Lines      188310   188999     +689     
  Branches    35963    35985      +22     
==========================================
+ Hits       165630   166295     +665     
- Misses      15854    15867      +13     
- Partials     6826     6837      +11     
Files with missing lines Coverage Ξ”
src/node_builtins.h 100.00% <ΓΈ> (ΓΈ)

... and 73 files with indirect coverage changes

codecov[bot] avatar Dec 04 '24 23:12 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63893/

nodejs-github-bot avatar Dec 05 '24 10:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63908/

nodejs-github-bot avatar Dec 06 '24 06:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63912/

nodejs-github-bot avatar Dec 06 '24 10:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63961/

nodejs-github-bot avatar Dec 09 '24 17:12 nodejs-github-bot

Landed in 64cc3b83268c76ade4b8f29109a64eef2016da79

nodejs-github-bot avatar Dec 11 '24 17:12 nodejs-github-bot