nodejs
assert: partialDeepStrictEqual now handles comparisons of ArrayBuffers, SharedArrayBuffers and Int16Arrays
Fixes: https://github.com/nodejs/node/issues/56097
Added handling for ArrayBuffers, SharedArrayBuffers and Int16Arrays , which were not properly considered in the new method assert.partialDeepStrictEqual .
This PR should move the feature one step closer to a stable version
Codecov Report
:x: Patch coverage is 97.20670% with 5 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 88.01%. Comparing base (3f9c6c0) to head (b4ba259).
:warning: Report is 1829 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| lib/assert.js | 97.20% | 4 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #56098 +/- ##
==========================================
+ Coverage 87.99% 88.01% +0.01%
==========================================
Files 656 656
Lines 189000 189234 +234
Branches 35992 36030 +38
==========================================
+ Hits 166308 166550 +242
- Misses 15851 15853 +2
+ Partials 6841 6831 -10
| Files with missing lines | Coverage Δ | |
|---|---|---|
| lib/assert.js | 99.10% <97.20%> (+0.09%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
The commit message doesn't fit our guidelines, the word just after the subsystem should be a verb in infinitive form.
Commit Queue failed
- Loading data for nodejs/node/pull/56098 ✔ Done loading data for nodejs/node/pull/56098 ----------------------------------- PR info ------------------------------------ Title assert: partialDeepStrictEqual now handles comparisons of ArrayBuffers, SharedArrayBuffers and Int16Arrays (#56098) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch puskin94:partial-deep-strict-equal-array-buffer-int-16-array -> nodejs:main Labels assert, author ready, needs-ci Commits 1 - assert: make partialDeepStrictEqual work with ArrayBuffers Committers 1 - Giovanni <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56098 Fixes: https://github.com/nodejs/node/issues/56097 Reviewed-By: Antoine du Hamel <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56098 Fixes: https://github.com/nodejs/node/issues/56097 Reviewed-By: Antoine du Hamel <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 01 Dec 2024 14:13:09 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/56098#pullrequestreview-2486472658 ✘ This PR needs to wait 14 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-12-07T18:10:47Z: https://ci.nodejs.org/job/node-test-pull-request/63927/ - Querying data for job/node-test-pull-request/63927/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12216903231