node icon indicating copy to clipboard operation
node copied to clipboard

dgram: support blocklist in udp

Open theanarkh opened this issue 1 year ago • 2 comments

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

theanarkh avatar Nov 29 '24 20:11 theanarkh

Review requested:

  • [ ] @nodejs/net

nodejs-github-bot avatar Nov 29 '24 20:11 nodejs-github-bot

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.00%. Comparing base (4211ab5) to head (8e6556f). Report is 91 commits behind head on main.

Files with missing lines Patch % Lines
lib/dgram.js 83.33% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56087      +/-   ##
==========================================
- Coverage   88.00%   88.00%   -0.01%     
==========================================
  Files         656      656              
  Lines      189103   189138      +35     
  Branches    35999    36016      +17     
==========================================
+ Hits       166421   166444      +23     
+ Misses      15860    15854       -6     
- Partials     6822     6840      +18     
Files with missing lines Coverage Δ
lib/dgram.js 97.61% <83.33%> (+0.25%) :arrow_up:

... and 23 files with indirect coverage changes

codecov[bot] avatar Nov 29 '24 22:11 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64045/

nodejs-github-bot avatar Dec 13 '24 18:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/64051/

nodejs-github-bot avatar Dec 14 '24 10:12 nodejs-github-bot

Landed in a50f3d5d8a0470dde057f8ba283a10ce57993d38

nodejs-github-bot avatar Dec 15 '24 14:12 nodejs-github-bot