node icon indicating copy to clipboard operation
node copied to clipboard

[v22.x backport] module: add `findPackageJSON` util

Open JakobJingleheimer opened this issue 1 year ago • 8 comments

PR-URL: https://github.com/nodejs/node/pull/55412 Reviewed-By: Matteo Collina [email protected] Reviewed-By: Antoine du Hamel [email protected]

JakobJingleheimer avatar Nov 29 '24 15:11 JakobJingleheimer

Review requested:

  • [ ] @nodejs/loaders

nodejs-github-bot avatar Nov 29 '24 15:11 nodejs-github-bot

Can you also backport https://github.com/nodejs/node/pull/55543 in the same PR please?

aduh95 avatar Nov 29 '24 16:11 aduh95

Can you also backport https://github.com/nodejs/node/pull/55543 in the same PR please?

Looks like the answer is yes 🙂

https://github.com/nodejs/node/pull/55543#issuecomment-2508015971

JakobJingleheimer avatar Nov 29 '24 16:11 JakobJingleheimer

Can you also backport #55543 in the same PR please?

Well that was easy 😁

JakobJingleheimer avatar Nov 29 '24 16:11 JakobJingleheimer

CI: https://ci.nodejs.org/job/node-test-pull-request/63780/

nodejs-github-bot avatar Nov 29 '24 16:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63794/

nodejs-github-bot avatar Nov 29 '24 22:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63798/

nodejs-github-bot avatar Nov 30 '24 00:11 nodejs-github-bot

It looks like everything is green but coverage, which seems bogus: it passed on the original. To my knowledge, it already has full coverage (aside from https://github.com/nodejs/node/pull/55822), so I'm not sure how to address this.

JakobJingleheimer avatar Nov 30 '24 09:11 JakobJingleheimer

Landed in 552a1823c32...4f85047aaef

aduh95 avatar Dec 10 '24 21:12 aduh95