node
node copied to clipboard
deps: cherry-pick 88260bf from node-gyp upstream
This change cherry-picks a small change from node-gyp needed for running native tests on ClangCL compiled binaries. The change was already approved here, so this is just the official port after the changes landed in node-gyp. Next is the part of the description regarding this change from the original PR:
Enforce MSVC to be used for node-gyp. As far as I can tell, this is the intended way of using node-gyp on Windows. The issue with running the native suites is that now we use Clang to compile Node.js, so config.variables.clang is set to 1, which makes node-gyp generate project files for ClangCL. While we'd like to enable this, that is currently not the priority so for now enforcing MSVC would be the way to go the way I see it. The changes in create-config-gypi.js would be done as a PR in node-gyp and then floated in Node.js until the next node-gyp update.
Tagging relative teams: @nodejs/platform-windows @nodejs/node-gyp
P.S. Since it's already reviewed, I'll request fast-tracking and I'm planning to land it after the first approval.
Refs: https://github.com/nodejs/node-gyp/pull/3098 Refs: https://github.com/nodejs/node/pull/55784