web streams: commit pull-into descriptors after filling from queue

[MattiasBuelens]

Implements https://github.com/whatwg/streams/pull/1326

Fixes #56044

[nodejs-github-bot]

Review requested:

• [ ] @nodejs/web-standards

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63773/

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.01%. Comparing base (4efb7ae) to head (b49a05e). Report is 324 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56072      +/-   ##
==========================================
+ Coverage   87.99%   88.01%   +0.01%     
==========================================
  Files         656      656              
  Lines      188988   189016      +28     
  Branches    35988    35999      +11     
==========================================
+ Hits       166302   166354      +52     
+ Misses      15848    15835      -13     
+ Partials     6838     6827      -11     

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	98.44% <100.00%> (+0.12%)	:arrow_up:
lib/internal/webstreams/util.js	94.64% <100.00%> (+0.20%)	:arrow_up:

... and 23 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63825/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/56072
✔  Done loading data for nodejs/node/pull/56072
----------------------------------- PR info ------------------------------------
Title      web streams: commit pull-into descriptors after filling from queue (#56072)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     MattiasBuelens:web-streams-commit-pull-intos-after-filling -> nodejs:main
Labels     author ready, web streams
Commits    2
 - stream: commit pull-into descriptors after filling from queue
 - test: update streams wpt
Committers 1
 - Mattias Buelens <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/56072
Reviewed-By: Matteo Collina <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56072
Reviewed-By: Matteo Collina <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 29 Nov 2024 12:08:50 GMT
   ✔  Approvals: 1
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/56072#pullrequestreview-2486198512
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-12-01T12:01:14Z: https://ci.nodejs.org/job/node-test-pull-request/63825/
- Querying data for job/node-test-pull-request/63825/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 56072
From https://github.com/nodejs/node
 * branch                  refs/pull/56072/merge -> FETCH_HEAD
✔  Fetched commits as 0547dcfc005a..b49a05e87903
--------------------------------------------------------------------------------
[main 45d05f9d2d] stream: commit pull-into descriptors after filling from queue
 Author: Mattias Buelens <[email protected]>
 Date: Thu Nov 28 00:04:18 2024 +0100
 2 files changed, 47 insertions(+), 19 deletions(-)
Auto-merging test/fixtures/wpt/README.md
Auto-merging test/fixtures/wpt/versions.json
[main 805e57e144] test: update streams wpt
 Author: Mattias Buelens <[email protected]>
 Date: Thu Nov 28 23:03:08 2024 +0100
 11 files changed, 161 insertions(+), 29 deletions(-)
 delete mode 100644 test/fixtures/wpt/streams/idlharness-shadowrealm.window.js
 create mode 100644 test/fixtures/wpt/streams/readable-byte-streams/patched-global.any.js
 create mode 100644 test/fixtures/wpt/streams/readable-streams/crashtests/from-cross-realm.https.html
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: commit pull-into descriptors after filling from queue
Fixes: https://github.com/nodejs/node/issues/56044
PR-URL: https://github.com/nodejs/node/pull/56072
Reviewed-By: Matteo Collina <[email protected]>
[detached HEAD 5441229c45] stream: commit pull-into descriptors after filling from queue
Author: Mattias Buelens <[email protected]>
Date: Thu Nov 28 00:04:18 2024 +0100
2 files changed, 47 insertions(+), 19 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: update streams wpt
PR-URL: https://github.com/nodejs/node/pull/56072
Reviewed-By: Matteo Collina <[email protected]>
[detached HEAD c74ee4984a] test: update streams wpt
Author: Mattias Buelens <[email protected]>
Date: Thu Nov 28 23:03:08 2024 +0100
11 files changed, 161 insertions(+), 29 deletions(-)
delete mode 100644 test/fixtures/wpt/streams/idlharness-shadowrealm.window.js
create mode 100644 test/fixtures/wpt/streams/readable-byte-streams/patched-global.any.js
create mode 100644 test/fixtures/wpt/streams/readable-streams/crashtests/from-cross-realm.https.html
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/12208247956

[nodejs-github-bot]

Landed in 0547dcfc005ae7d9b60d31a7edc90f5a180f907a...9c046ea8042c435d2cbecccbc1a1460630f59c3f