node icon indicating copy to clipboard operation
node copied to clipboard

src,build: add no user defined deduction guides of CTAD check

Open legendecas opened this issue 1 year ago β€’ 5 comments

To our secondary C++ style guide:

Do not use CTAD with a given template unless the template's maintainers have opted into supporting use of CTAD by providing at least one explicit deduction guide (all templates in the std namespace are also presumed to have opted in). This should be enforced with a compiler warning if available.

Ref: https://google.github.io/styleguide/cppguide.html#CTAD

To use CTAD with a template, it must be defined with at least one deduction guide (std templates are defined with guides). Enforcing this rule with compiler checks.

legendecas avatar Nov 29 '24 10:11 legendecas

Review requested:

  • [ ] @nodejs/gyp

nodejs-github-bot avatar Nov 29 '24 10:11 nodejs-github-bot

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.01%. Comparing base (d09458f) to head (8d59040). Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
src/quic/session.cc 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56071      +/-   ##
==========================================
+ Coverage   87.96%   88.01%   +0.04%     
==========================================
  Files         656      656              
  Lines      188384   188988     +604     
  Branches    35968    35989      +21     
==========================================
+ Hits       165707   166331     +624     
- Misses      15845    15846       +1     
+ Partials     6832     6811      -21     
Files with missing lines Coverage Ξ”
src/quic/session.cc 5.35% <0.00%> (ΓΈ)

... and 31 files with indirect coverage changes

codecov[bot] avatar Nov 29 '24 13:11 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63786/

nodejs-github-bot avatar Nov 29 '24 17:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63839/

nodejs-github-bot avatar Dec 02 '24 15:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63902/

nodejs-github-bot avatar Dec 05 '24 16:12 nodejs-github-bot

Landed in 4211ab56ccdb62b980f456cae34821e4622b40a2

nodejs-github-bot avatar Dec 06 '24 09:12 nodejs-github-bot