node icon indicating copy to clipboard operation
node copied to clipboard

stream: validate undefined sizeAlgorithm in WritableStream

Open jazelly opened this issue 1 year ago • 3 comments

No test was added since it was covered by existing WPT, and the spec change did not introduce WPT updates

Fixes: https://github.com/nodejs/node/issues/56014 Refs: https://github.com/whatwg/streams/pull/1333

jazelly avatar Nov 29 '24 03:11 jazelly

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.00%. Comparing base (4cf6fab) to head (fce3fd9). Report is 152 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56067   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files         656      656           
  Lines      188988   188997    +9     
  Branches    35992    35991    -1     
=======================================
+ Hits       166315   166324    +9     
+ Misses      15838    15832    -6     
- Partials     6835     6841    +6     
Files with missing lines Coverage Δ
lib/internal/webstreams/writablestream.js 99.85% <100.00%> (+<0.01%) :arrow_up:

... and 27 files with indirect coverage changes

codecov[bot] avatar Nov 29 '24 05:11 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63763/

nodejs-github-bot avatar Nov 29 '24 06:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63812/ 💛

nodejs-github-bot avatar Nov 30 '24 11:11 nodejs-github-bot

Landed in 57b21b16d20f7327dca870dca3a1998e5dc10b6c

nodejs-github-bot avatar Dec 20 '24 06:12 nodejs-github-bot