node icon indicating copy to clipboard operation
node copied to clipboard

src: switch from `Get/SetPrototype` to `Get/SetPrototypeV2`

Open avivkeller opened this issue 1 year ago • 3 comments

Ref #55452

GetPrototype has been deprecated in favor of GetPrototypeV2. See https://issues.chromium.org/issues/333672197

avivkeller avatar Oct 18 '24 23:10 avivkeller

Review requested:

  • [ ] @nodejs/node-api

nodejs-github-bot avatar Oct 18 '24 23:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63195/

nodejs-github-bot avatar Oct 18 '24 23:10 nodejs-github-bot

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (7ae193d) to head (5d3c0bb). Report is 263 commits behind head on main.

Files with missing lines Patch % Lines
src/node_constants.cc 0.00% 0 Missing and 10 partials :warning:
src/api/environment.cc 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55453   +/-   ##
=======================================
  Coverage   88.40%   88.41%           
=======================================
  Files         653      653           
  Lines      187600   187507   -93     
  Branches    36117    36104   -13     
=======================================
- Hits       165854   165784   -70     
+ Misses      14974    14959   -15     
+ Partials     6772     6764    -8     
Files with missing lines Coverage Δ
src/internal_only_v8.cc 80.00% <100.00%> (ø)
src/js_native_api_v8.cc 76.51% <100.00%> (ø)
src/node_buffer.cc 70.36% <100.00%> (-0.21%) :arrow_down:
src/node_options.cc 87.44% <100.00%> (+0.03%) :arrow_up:
src/node_webstorage.cc 72.20% <100.00%> (ø)
src/api/environment.cc 75.81% <0.00%> (-0.20%) :arrow_down:
src/node_constants.cc 97.05% <0.00%> (ø)

... and 34 files with indirect coverage changes

codecov[bot] avatar Oct 19 '24 00:10 codecov[bot]

Landed in e4ca097f566f9951e42c8ff9106e94cd0fe3a031

nodejs-github-bot avatar Oct 22 '24 05:10 nodejs-github-bot

This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.

ruyadorno avatar Nov 27 '24 07:11 ruyadorno