node icon indicating copy to clipboard operation
node copied to clipboard

sqlite: refactor open options

Open tniessen opened this issue 1 year ago β€’ 1 comments

Move options that are only relevant for opening the database into a self-contained class.

Refs: https://github.com/nodejs/node/pull/54777#discussion_r1745988310

tniessen avatar Oct 18 '24 09:10 tniessen

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (ddfef05) to head (dc87f5c). Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 87.50% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55442      +/-   ##
==========================================
- Coverage   88.42%   88.40%   -0.02%     
==========================================
  Files         652      653       +1     
  Lines      186918   187605     +687     
  Branches    36079    36120      +41     
==========================================
+ Hits       165279   165851     +572     
- Misses      14892    14979      +87     
- Partials     6747     6775      +28     
Files with missing lines Coverage Ξ”
src/node_sqlite.h 73.33% <100.00%> (+73.33%) :arrow_up:
src/node_sqlite.cc 83.36% <87.50%> (-0.37%) :arrow_down:

... and 104 files with indirect coverage changes

codecov[bot] avatar Oct 18 '24 11:10 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63277/

nodejs-github-bot avatar Oct 24 '24 17:10 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/55442
βœ”  Done loading data for nodejs/node/pull/55442
----------------------------------- PR info ------------------------------------
Title      sqlite: refactor open options (#55442)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:sqlite-refactor-open-options -> nodejs:main
Labels     c++, needs-ci, sqlite
Commits    1
 - sqlite: refactor open options
Committers 1
 - Tobias Nießen <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55442
Reviewed-By: Benjamin Gruenbaum <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55442
Reviewed-By: Benjamin Gruenbaum <[email protected]>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Fri, 18 Oct 2024 09:54:50 GMT
   βœ”  Approvals: 1
   βœ”  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/55442#pullrequestreview-2377857073
   ✘  This PR needs to wait 10 more hours to land (or 0 hours if there is one more approval)
   βœ”  Last GitHub CI successful
   β„Ή  Last Full PR CI on 2024-10-24T17:37:49Z: https://ci.nodejs.org/job/node-test-pull-request/63277/
- Querying data for job/node-test-pull-request/63277/
   βœ”  Last Jenkins CI successful
--------------------------------------------------------------------------------
   βœ”  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/11509076184

nodejs-github-bot avatar Oct 24 '24 23:10 nodejs-github-bot

Landed in 0668e64cea127d8d4fa35d1b49bf11093ecc728f

nodejs-github-bot avatar Oct 26 '24 00:10 nodejs-github-bot