node
node copied to clipboard
sqlite: refactor open options
Move options that are only relevant for opening the database into a self-contained class.
Refs: https://github.com/nodejs/node/pull/54777#discussion_r1745988310
Codecov Report
Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
Project coverage is 88.40%. Comparing base (
ddfef05) to head (dc87f5c). Report is 63 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/node_sqlite.cc | 87.50% | 1 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #55442 +/- ##
==========================================
- Coverage 88.42% 88.40% -0.02%
==========================================
Files 652 653 +1
Lines 186918 187605 +687
Branches 36079 36120 +41
==========================================
+ Hits 165279 165851 +572
- Misses 14892 14979 +87
- Partials 6747 6775 +28
| Files with missing lines | Coverage Ξ | |
|---|---|---|
| src/node_sqlite.h | 73.33% <100.00%> (+73.33%) |
:arrow_up: |
| src/node_sqlite.cc | 83.36% <87.50%> (-0.37%) |
:arrow_down: |
CI: https://ci.nodejs.org/job/node-test-pull-request/63277/
Commit Queue failed
- Loading data for nodejs/node/pull/55442 β Done loading data for nodejs/node/pull/55442 ----------------------------------- PR info ------------------------------------ Title sqlite: refactor open options (#55442) β Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:sqlite-refactor-open-options -> nodejs:main Labels c++, needs-ci, sqlite Commits 1 - sqlite: refactor open options Committers 1 - Tobias NieΓen <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55442 Reviewed-By: Benjamin Gruenbaum <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55442 Reviewed-By: Benjamin Gruenbaum <[email protected]> -------------------------------------------------------------------------------- βΉ This PR was created on Fri, 18 Oct 2024 09:54:50 GMT β Approvals: 1 β - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/55442#pullrequestreview-2377857073 β This PR needs to wait 10 more hours to land (or 0 hours if there is one more approval) β Last GitHub CI successful βΉ Last Full PR CI on 2024-10-24T17:37:49Z: https://ci.nodejs.org/job/node-test-pull-request/63277/ - Querying data for job/node-test-pull-request/63277/ β Last Jenkins CI successful -------------------------------------------------------------------------------- β Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11509076184
Landed in 0668e64cea127d8d4fa35d1b49bf11093ecc728f