fix(build): uninstall support AIX 7.1
This PR will fix #55437 , please have a look!
Can you update the commit message to be prefixed with "build" rather than "fix(build)"?
@abmusse Could you check if we need the same on IBM i?
Sorry, I don't have an IBM i machine yet.
Can you update the commit message to be prefixed with "build" rather than "fix(build)"?
Yes, updated. Please have a look!
CI: https://ci.nodejs.org/job/node-test-pull-request/63192/
CI: https://ci.nodejs.org/job/node-test-pull-request/63193/
CI: https://ci.nodejs.org/job/node-test-pull-request/63196/
CI: https://ci.nodejs.org/job/node-test-pull-request/63200/
CI: https://ci.nodejs.org/job/node-test-pull-request/63234/
Commit Queue failed
- Loading data for nodejs/node/pull/55438 ✔ Done loading data for nodejs/node/pull/55438 ----------------------------------- PR info ------------------------------------ Title fix(build): uninstall support AIX 7.1 (#55438) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cloorc:main -> nodejs:main Labels build, aix, python, author ready, needs-ci Commits 1 - build: fix uninstall script for AIX 7.1 Committers 1 - Cloorc <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55438 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Abdirahim Musse <[email protected]> Reviewed-By: Michael Dawson <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55438 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Abdirahim Musse <[email protected]> Reviewed-By: Michael Dawson <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 18 Oct 2024 03:20:11 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/55438#pullrequestreview-2378988172 ✔ - Abdirahim Musse (@abmusse): https://github.com/nodejs/node/pull/55438#pullrequestreview-2382538473 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/55438#pullrequestreview-2382544505 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-10-21T15:55:54Z: https://ci.nodejs.org/job/node-test-pull-request/63234/ - Querying data for job/node-test-pull-request/63234/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11445714148
CI: https://ci.nodejs.org/job/node-test-pull-request/63240/
CI: https://ci.nodejs.org/job/node-test-pull-request/63241/
Landed in fed28bf8134b20059cf96392a58abb8a81f8dca8