node icon indicating copy to clipboard operation
node copied to clipboard

fix(build): uninstall support AIX 7.1

Open cloorc opened this issue 1 year ago • 7 comments

This PR will fix #55437 , please have a look!

cloorc avatar Oct 18 '24 03:10 cloorc

Can you update the commit message to be prefixed with "build" rather than "fix(build)"?

avivkeller avatar Oct 18 '24 10:10 avivkeller

@abmusse Could you check if we need the same on IBM i?

Sorry, I don't have an IBM i machine yet.

cloorc avatar Oct 18 '24 12:10 cloorc

Can you update the commit message to be prefixed with "build" rather than "fix(build)"?

Yes, updated. Please have a look!

cloorc avatar Oct 18 '24 14:10 cloorc

CI: https://ci.nodejs.org/job/node-test-pull-request/63192/

nodejs-github-bot avatar Oct 18 '24 21:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63193/

nodejs-github-bot avatar Oct 18 '24 23:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63196/

nodejs-github-bot avatar Oct 19 '24 00:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63200/

nodejs-github-bot avatar Oct 19 '24 12:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63234/

nodejs-github-bot avatar Oct 21 '24 15:10 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/55438
✔  Done loading data for nodejs/node/pull/55438
----------------------------------- PR info ------------------------------------
Title      fix(build): uninstall support AIX 7.1 (#55438)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     cloorc:main -> nodejs:main
Labels     build, aix, python, author ready, needs-ci
Commits    1
 - build: fix uninstall script for AIX 7.1
Committers 1
 - Cloorc <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55438
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Abdirahim Musse <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55438
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Abdirahim Musse <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 18 Oct 2024 03:20:11 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/55438#pullrequestreview-2378988172
   ✔  - Abdirahim Musse (@abmusse): https://github.com/nodejs/node/pull/55438#pullrequestreview-2382538473
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/55438#pullrequestreview-2382544505
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-10-21T15:55:54Z: https://ci.nodejs.org/job/node-test-pull-request/63234/
- Querying data for job/node-test-pull-request/63234/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/11445714148

nodejs-github-bot avatar Oct 21 '24 17:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63240/

nodejs-github-bot avatar Oct 21 '24 18:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63241/

nodejs-github-bot avatar Oct 21 '24 18:10 nodejs-github-bot

Landed in fed28bf8134b20059cf96392a58abb8a81f8dca8

nodejs-github-bot avatar Oct 21 '24 19:10 nodejs-github-bot