node icon indicating copy to clipboard operation
node copied to clipboard

dns: stop using deprecated `ares_query`

Open avivkeller opened this issue 1 year ago β€’ 3 comments

Ref: #52464

ares_query has been deprecated in favor of ares_query_dnsrec, so this PR switches our implementation to use it.

avivkeller avatar Oct 17 '24 18:10 avivkeller

Review requested:

  • [ ] @nodejs/net

nodejs-github-bot avatar Oct 17 '24 18:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63165/

nodejs-github-bot avatar Oct 17 '24 19:10 nodejs-github-bot

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.43%. Comparing base (fa8f149) to head (e9916ad). Report is 93 commits behind head on main.

Files with missing lines Patch % Lines
src/cares_wrap.cc 41.66% 7 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55430      +/-   ##
==========================================
+ Coverage   88.41%   88.43%   +0.01%     
==========================================
  Files         652      654       +2     
  Lines      186918   187661     +743     
  Branches    36072    36119      +47     
==========================================
+ Hits       165270   165949     +679     
- Misses      14891    14946      +55     
- Partials     6757     6766       +9     
Files with missing lines Coverage Ξ”
src/cares_wrap.h 79.89% <100.00%> (+2.18%) :arrow_up:
src/cares_wrap.cc 65.16% <41.66%> (ΓΈ)

... and 143 files with indirect coverage changes

codecov[bot] avatar Oct 17 '24 19:10 codecov[bot]

Hey, can I have some reviews? Thanks!

avivkeller avatar Oct 21 '24 18:10 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/63332/

nodejs-github-bot avatar Oct 29 '24 06:10 nodejs-github-bot

CI is 🟒 ! Can somone commit-queue this? Thx!

avivkeller avatar Oct 30 '24 13:10 avivkeller

Landed in 8807549ed9f6eaf6842ae56b8ac55ab385951636

nodejs-github-bot avatar Oct 30 '24 14:10 nodejs-github-bot