node icon indicating copy to clipboard operation
node copied to clipboard

build: conditionally compile bundled sqlite

Open richardlau opened this issue 1 year ago • 2 comments

Only compile the bundled sqlite in deps/sqlite if Node.js was not configured with --shared-sqlite.

node.gypi is already correctly adding the sqlite dependency if node_shared_sqlite=="false" so the unconditional entries in node.gyp are not necessary.


It looks like there are other dependencies that would need a similar change, but I'm not including those here because the sqlite dependency is much easier to check (deleting the deps/sqlite directory and linking against (with --shared-sqlite) libsqlite3-dev on Ubuntu or sqlite-devel on Fedora).

richardlau avatar Oct 16 '24 17:10 richardlau

Review requested:

  • [ ] @nodejs/gyp

nodejs-github-bot avatar Oct 16 '24 17:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63144/

nodejs-github-bot avatar Oct 16 '24 18:10 nodejs-github-bot

Landed in e92446536ed4e268c9eef6ae6f911e384c98eecf

nodejs-github-bot avatar Oct 21 '24 16:10 nodejs-github-bot