node icon indicating copy to clipboard operation
node copied to clipboard

dgram: add UV_UDP_REUSEPORT for udp

Open theanarkh opened this issue 1 year ago • 12 comments

UV_UDP_REUSEPORT allows users to bind a port to multiple sockets. Refs: https://github.com/libuv/libuv/pull/4419

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

theanarkh avatar Oct 16 '24 11:10 theanarkh

Review requested:

  • [ ] @nodejs/net

nodejs-github-bot avatar Oct 16 '24 11:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63139/

nodejs-github-bot avatar Oct 16 '24 11:10 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.40%. Comparing base (7a7c2b3) to head (c563569). Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55403      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files         652      653       +1     
  Lines      186878   187491     +613     
  Branches    36061    36094      +33     
==========================================
+ Hits       165236   165751     +515     
- Misses      14895    14970      +75     
- Partials     6747     6770      +23     
Files with missing lines Coverage Δ
lib/dgram.js 97.33% <100.00%> (+0.01%) :arrow_up:
src/udp_wrap.cc 78.71% <100.00%> (+0.04%) :arrow_up:

... and 119 files with indirect coverage changes

codecov[bot] avatar Oct 16 '24 12:10 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63141/

nodejs-github-bot avatar Oct 16 '24 17:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63145/

nodejs-github-bot avatar Oct 16 '24 18:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63153/

nodejs-github-bot avatar Oct 17 '24 06:10 nodejs-github-bot

Title should be dgram: add UV_TCP_REUSEPORT, right?

addaleax avatar Oct 17 '24 18:10 addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/63171/

nodejs-github-bot avatar Oct 18 '24 09:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63174/

nodejs-github-bot avatar Oct 18 '24 10:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63187/

nodejs-github-bot avatar Oct 18 '24 16:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63205/

nodejs-github-bot avatar Oct 19 '24 20:10 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63207/ 💚

nodejs-github-bot avatar Oct 19 '24 22:10 nodejs-github-bot

Landed in 6a02c2701e34eebcbbbeced061507af7d6481820

nodejs-github-bot avatar Oct 21 '24 10:10 nodejs-github-bot