nodejs
build: apply cpp linting and formatting to ncrypto
CC @jasnell (who appears to have contributed most of this work)
If these files are maintained in this repository, should they not follow the same linting / formatting rules? This PR has clang-format and cpplint apply to these files.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.91%. Comparing base (
68dc15e) to head (786d5fa). Report is 873 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #55362 +/- ##
==========================================
- Coverage 88.40% 87.91% -0.50%
==========================================
Files 654 654
Lines 187637 187746 +109
Branches 36098 35818 -280
==========================================
- Hits 165887 165057 -830
- Misses 14994 15885 +891
- Partials 6756 6804 +48
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
btw, the intention is to move ncrypto out to a separate repo once all of the work is done to separate it out. It'll be a while tho. At that time that separate project will have its own build and linting stuff
Hey, can someone restart the failed builds so this fix can land? Thanks!
@jasnell would you mind re-approving + CI-ing now that a new commit has been added?
Why would we be linting a vendored dependency? 🤔
Because we are the author of the dependency. It's our dependency, and it lives in this repository, shouldn't it follow the same lint rules?
If/when ncrypto is moved to its own repository, this can be changed.
the intention is to move ncrypto out to a separate repo once all of the work is done to separate it out. It'll be a while tho.
Does it need to be you doing that, or could it be anyone doing that? It seems to me we should do that instead of applying a linter in deps
Does it need to be you doing that....
No, but the process of separating these out into the dependency is tedious and difficult to get right without introducing breaking changes. I would rather it be done after that work is completed to make code reviews easier. In the meantime the linting and stuff is annoying and applying it here is useful.