node icon indicating copy to clipboard operation
node copied to clipboard

src,test: drop SlowBuffer

Open RafaelGSS opened this issue 1 year ago • 4 comments

Depends on https://github.com/nodejs/node/pull/55175.

It should land only on Node.js 24*.

To avoid inconsistencies, I'm adding a blocked label so we land on main only when 23 goes out.

RafaelGSS avatar Sep 30 '24 13:09 RafaelGSS

Review requested:

  • [ ] @nodejs/performance

nodejs-github-bot avatar Sep 30 '24 13:09 nodejs-github-bot

The removal of a feature must be semver major. Additionally, with this being semver major, it doesn't need all the "don't-land" labels, as it can't land on LTS lines anyway, right?

avivkeller avatar Oct 01 '24 01:10 avivkeller

The removal of a feature must be semver major. Additionally, with this being semver major, it doesn't need all the "don't-land" labels, as it can't land on LTS lines anyway, right?

Incorrect. It will be next-semver-major, it should not land on v23.x.

RafaelGSS avatar Oct 01 '24 17:10 RafaelGSS

The blocking PR has landed, and this PR can no longer land on v23 due to the semver-major label. I've updated the labels accordingly.

avivkeller avatar Oct 16 '24 14:10 avivkeller

I'm open a fresh PR once v24 goes out :)

RafaelGSS avatar Oct 21 '24 18:10 RafaelGSS