node icon indicating copy to clipboard operation
node copied to clipboard

test_runner: avoid spread operator on arrays

Open aduh95 opened this issue 1 year ago • 3 comments

aduh95 avatar Sep 27 '24 15:09 aduh95

Review requested:

  • [ ] @nodejs/test_runner

nodejs-github-bot avatar Sep 27 '24 15:09 nodejs-github-bot

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (fbc6fcb) to head (979af26). Report is 358 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/runner.js 33.33% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55143   +/-   ##
=======================================
  Coverage   88.23%   88.24%           
=======================================
  Files         651      651           
  Lines      183914   183901   -13     
  Branches    35865    35862    -3     
=======================================
+ Hits       162279   162282    +3     
+ Misses      14910    14904    -6     
+ Partials     6725     6715   -10     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.94% <100.00%> (+<0.01%) :arrow_up:
lib/internal/test_runner/runner.js 86.75% <33.33%> (-0.10%) :arrow_down:

... and 20 files with indirect coverage changes

codecov[bot] avatar Sep 27 '24 16:09 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62819/

nodejs-github-bot avatar Sep 28 '24 10:09 nodejs-github-bot

Landed in 103b8439cae2a113f4f0796dd6fcbced294a3ed8

nodejs-github-bot avatar Sep 29 '24 15:09 nodejs-github-bot