nodejs
test: adding more tests for strip-types
In this MR I'm adding more tests created in this PR, testing generics and Utility Types. This PR makes part of typescript iniciative on Node.
cc: @RedYetiDev @marco-ippolito @ErickWendel
Again commits do not point to your github profile or email
The commits point to Kevin Uehara <[email protected]>, whereas your github profile's commits point to Gayathri <[email protected]>
@marco-ippolito @RedYetiDev I update the author of commits... the ifood account is my work author :)
@marco-ippolito how does this fixture compare to the other ones? Just want to make sure they are all similar
To be honest I dont think there is much value in testing TypeScript features such as Unions and Generics, since we rely on swc and swc tests that the output they produce is correct. Im ok with asserting that parameter properties throw in striptypes mode
@marco-ippolito @RedYetiDev Do you think we can approve and merge this PR?
@RedYetiDev can you review and approve the PR? 🙏
I'm not a core collaborator, so my reviews have no approving power. But, LGTM.
@RedYetiDev can you review and approve the PR? 🙏
I'm not a core collaborator, so my reviews have no approving power. But, LGTM.
Thanks!! Now who can merge the PR?
It's been labelled author ready. A maintainer can add commit-queue if they feel confident this should land.
@kevinuehara can you rebase/squash the merge commit + resolve the lint error?
@kevinuehara can you rebase/squash the merge commit + resolve the lint error?
Sorry! But can you help me with the rebase/squash the merge coomit? Is there any command to solve the lint problem?
make lint-jswill lint, whilemake lint-js-fixwill fix some of the errorsgit rebase -i HEAD~n, wherenrepresents the number of commits, will open a UI where you canpick/squashcommits. See https://www.freecodecamp.org/news/git-squash-commits/
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.24%. Comparing base (
c237eab) to head (240c9e9). Report is 405 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #54929 +/- ##
==========================================
- Coverage 88.26% 88.24% -0.02%
==========================================
Files 652 652
Lines 183898 183898
Branches 35859 35858 -1
==========================================
- Hits 162309 162286 -23
- Misses 14891 14898 +7
- Partials 6698 6714 +16
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@RedYetiDev I'm having some troube to use the squash/merge... I'm thinking to close this PR and open a new one, what do you think?
What's the issue you are having?
git reset --soft HEAD~<n> # where <n> represents the number of commits, in this case, 9
git commit
May also work. (See https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together)
What's the issue you are having?
When I use the git rebase -i HEAD~2 all these commits appear due to the update with main:
Oh okay. IIRC what you'll want to do is get the latest commit from main, and run
git reset --hard <commit> # Right now it's c237eabf4c8f1d5ff6dfa95ae30930d6fc959d4e
[!CAUTION] This is a dangerous command. It'll remove all uncommitted changes, and revert your local workspace to look identical to
<commit>(c237eabf4c8f1d5ff6dfa95ae30930d6fc959d4e)
After this, re-add the changes from this PR. This can be done manually, or via git apply path/to/file.diff with the PR's diff file.
Once this is done, you can git add . and git commit
@RedYetiDev @marco-ippolito I saw that an error was occurring in the tests, but it was not one that I created or changed. Can you help?
@RedYetiDev @marco-ippolito I saw that an error was occurring in the tests, but it was not one that I created or changed. Can you help?
Its just flaky tests Ill re run the CI
https://ci.nodejs.org/job/node-test-commit-arm/55143/nodes=rhel8-arm64/testReport/junit/(root)/parallel/test_stream_readable_unpipe_resume/ looks flaky.