node icon indicating copy to clipboard operation
node copied to clipboard

test: add test cases for `getDirents` and `getDirent` function

Open sendoru opened this issue 1 year ago • 3 comments

Add test case when type is not UV_DIRENT_UNKNOWN for test case of getDirent Add test case when path is a nonexistent path for test case of getDirents and getDirent

This improves the branch coverage of lib/internal/fs/utils.js.

sendoru avatar Aug 29 '24 13:08 sendoru

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.25%. Comparing base (9db6327) to head (885bc55). Report is 170 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54634      +/-   ##
==========================================
+ Coverage   88.05%   88.25%   +0.19%     
==========================================
  Files         651      651              
  Lines      183405   183871     +466     
  Branches    35822    35857      +35     
==========================================
+ Hits       161499   162273     +774     
+ Misses      15159    14895     -264     
+ Partials     6747     6703      -44     

see 140 files with indirect coverage changes

codecov[bot] avatar Aug 29 '24 15:08 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61753/

nodejs-github-bot avatar Aug 31 '24 16:08 nodejs-github-bot

I've made some mistakes when rebasing... Force push is for revert it and it should be fixed now

sendoru avatar Sep 01 '24 01:09 sendoru