node icon indicating copy to clipboard operation
node copied to clipboard

Adding TCP_FASTOPEN_CONNECT prevents compiling on older systems

Open abcbarryn opened this issue 6 months ago • 5 comments

Version

v22.7.0

Platform

Linux static1 3.19.4-1.g51ddeac-desktop #1 SMP PREEMPT Mon Apr 13 13:20:55 UTC 2015 (51ddeac) x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

Attempt to compile nodejs on an older system that lacks support for TCP_FASTOPEN_CONNECT.

How often does it reproduce? Is there a required condition?

All the time.

What is the expected behavior? Why is that the expected behavior?

Be able to compile/build nodejs from source.

What do you see instead?

error: ‘TCP_FASTOPEN_CONNECT’ undeclared (first use in this function)

Multiple instances of this

Additional information

Please implement an option to disable this feature if the target platform does not support it.

Also, read this: https://blog.apnic.net/2021/07/05/tcp-fast-open-not-so-fast/

abcbarryn avatar Aug 28 '24 06:08 abcbarryn