node icon indicating copy to clipboard operation
node copied to clipboard

test: increase key size for ca2-cert.pem

Open mhdawson opened this issue 1 year ago • 2 comments

Refs: https://github.com/nodejs/node/pull/44498 Refs: https://github.com/nodejs/node/issues/53382

Key sizes were increased to 2048 in PR 44498 including the configuration file for the generation of ca2-cert.pem. However, it seems like updating ca2-cert.pem and related files themselves were missed as they were not updated in the PR and the ca2-cert.pem reported as being associated with a 1024 bit key. I believe that was the cause of some of the failures mentioned in https://github.com/nodejs/node/issues/53382 as OpenSSL 3.2 increased the default security level from 1 to 2 and that would mean that certificates associated with keys of 1024 bits would no longer be accepted.

This PR updates the key size for ca2-cert.pem. It was not necessary to change the config, only run the generation for the ca2-cert.pem and related files.

mhdawson avatar Aug 27 '24 23:08 mhdawson

Test on OpenSSL 3.2 and variants - https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/31/

mhdawson avatar Aug 27 '24 23:08 mhdawson

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.33%. Comparing base (0b3ae01) to head (27d19d6). Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54599      +/-   ##
==========================================
+ Coverage   87.32%   87.33%   +0.01%     
==========================================
  Files         649      649              
  Lines      182570   182570              
  Branches    35026    35032       +6     
==========================================
+ Hits       159432   159455      +23     
+ Misses      16406    16388      -18     
+ Partials     6732     6727       -5     

see 28 files with indirect coverage changes

codecov[bot] avatar Aug 28 '24 01:08 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61588/

nodejs-github-bot avatar Aug 28 '24 13:08 nodejs-github-bot

Looks like the run with OpenSSL32 confirms that it fixed up a bunch of tests :)

mhdawson avatar Aug 28 '24 14:08 mhdawson

CI: https://ci.nodejs.org/job/node-test-pull-request/61598/

nodejs-github-bot avatar Aug 28 '24 17:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61600/

nodejs-github-bot avatar Aug 28 '24 19:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61613/

nodejs-github-bot avatar Aug 28 '24 22:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61622/

nodejs-github-bot avatar Aug 29 '24 00:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61657/

nodejs-github-bot avatar Aug 29 '24 13:08 nodejs-github-bot

Landed in 01f751b529d126529f1d2019f0dcb13b8e54b787

nodejs-github-bot avatar Aug 29 '24 23:08 nodejs-github-bot