nodejs
tty: fix links for terminal colors
This PR updates the links for TTY's terminal colors.
For Terminator, according to author of the original link (The bolded Here is the new link):
For Terminator users, there is a branch for GTK+3 version, which supports true colors and much more, but it's not yet merged in the master and not yet released as well. Here is the bug for pushing it upstream. So if you want to help this - you can test it more, write patches and ping developers. Looks like this one is almost ready, I see no big stoppers against merging this branch in the master and releasing a new version of Terminator.
For rxvt-unicode-24bit, the link was changed to that mentioned by https://github.com/termstandard/colors.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.34%. Comparing base (
a7271ab) to head (9519136). Report is 330 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #54596 +/- ##
=======================================
Coverage 87.33% 87.34%
=======================================
Files 649 649
Lines 182570 182570
Branches 35040 35027 -13
=======================================
+ Hits 159454 159462 +8
+ Misses 16390 16381 -9
- Partials 6726 6727 +1
| Files with missing lines | Coverage Ξ | |
|---|---|---|
| lib/internal/tty.js | 97.04% <100.00%> (ΓΈ) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
This doesn't need a CI to land, and has an approval:
author ready?
This changes source code (even if it's comments) so needs a full CI.
This changes source code (even if it's comments) so needs a full CI.
Out of curiosity, what's the reason behind that?
This changes source code (even if it's comments) so needs a full CI.
Out of curiosity, what's the reason behind that?
It's an extra level of checks to guard against, e.g. accidentally commenting out code. I also think at one point js2c couldn't handle some Unicode characters (possibly fixed now?).
Also https://www.bleepingcomputer.com/news/security/invisible-characters-could-be-hiding-backdoors-in-your-javascript-code/.
Because this only modifies comments, and the CI looks good, should needs-ci be removed, because even if anything changes, it won't break this?
Also can this land?
