node icon indicating copy to clipboard operation
node copied to clipboard

test,crypto: update WebCryptoAPI WPT

Open panva opened this issue 1 year ago • 6 comments

This PR:

  • updates the WebCryptoAPI WPTs to the latest using git node wpt WebCryptoAPI
  • updates the WPT runner to allow for CJS status files so that more complex expectations can be defined

The CJS status file is necessary for this update since the vectors the WPT update is adding are passing on the Jenkins CI s390x nodes but fail everywhere else, I would love to know why but I didn't dig into it much. Marking the tests as flaky is not accurate, so instead the CJS status file allows to detect os.arch() and change the expectations accordingly.

Refs: #54572 Refs: #54468

cc @RedYetiDev

Note: I can potentially split the WPT runner update and WebCryptoAPI WPT pull into two separate commits with a rebase label in this PR.

panva avatar Aug 27 '24 16:08 panva

Review requested:

  • [ ] @nodejs/web-standards

nodejs-github-bot avatar Aug 27 '24 16:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61562/

nodejs-github-bot avatar Aug 27 '24 16:08 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.34%. Comparing base (4ce9864) to head (e36c683). Report is 2252 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #54593   +/-   ##
=======================================
  Coverage   87.33%   87.34%           
=======================================
  Files         649      649           
  Lines      182623   182570   -53     
  Branches    35041    35026   -15     
=======================================
- Hits       159498   159459   -39     
+ Misses      16400    16390   -10     
+ Partials     6725     6721    -4     

see 42 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 27 '24 18:08 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61573/

nodejs-github-bot avatar Aug 28 '24 05:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61575/

nodejs-github-bot avatar Aug 28 '24 06:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61576/

nodejs-github-bot avatar Aug 28 '24 07:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61581/

nodejs-github-bot avatar Aug 28 '24 11:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61592/

nodejs-github-bot avatar Aug 28 '24 14:08 nodejs-github-bot

Landed in fc02b88f89f8d5abf5ee4414a1026444c18d77b3

nodejs-github-bot avatar Aug 29 '24 16:08 nodejs-github-bot

v20.x backport in https://github.com/nodejs/node/pull/58589

panva avatar Jun 05 '25 14:06 panva