node
node copied to clipboard
buffer: throw when writing beyond buffer
This reverts commit dd8eeec3f036549f1d8ed3c8b648b80795a48099.
Codecov Report
Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
Project coverage is 87.33%. Comparing base (
dd8eeec) to head (2edea24). Report is 390 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| lib/internal/buffer.js | 66.66% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #54588 +/- ##
=======================================
Coverage 87.32% 87.33%
=======================================
Files 649 649
Lines 182621 182632 +11
Branches 35042 35040 -2
=======================================
+ Hits 159480 159498 +18
- Misses 16397 16398 +1
+ Partials 6744 6736 -8
| Files with missing lines | Coverage Ξ | |
|---|---|---|
| lib/internal/buffer.js | 97.41% <66.66%> (ΓΈ) |
CI: https://ci.nodejs.org/job/node-test-pull-request/61732/
CI: https://ci.nodejs.org/job/node-test-pull-request/61737/
PR is currently blocked from landing due to unreliable CI. Likely needs a rebase
CI: https://ci.nodejs.org/job/node-test-pull-request/62167/
CI: https://ci.nodejs.org/job/node-test-pull-request/62206/
CI: https://ci.nodejs.org/job/node-test-pull-request/62749/
CI: https://ci.nodejs.org/job/node-test-pull-request/62824/ π
Landed in 3800d60c661b