node icon indicating copy to clipboard operation
node copied to clipboard

buffer: throw when writing beyond buffer

Open ronag opened this issue 1 year ago β€’ 1 comments
trafficstars

This reverts commit dd8eeec3f036549f1d8ed3c8b648b80795a48099.

ronag avatar Aug 27 '24 08:08 ronag

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (dd8eeec) to head (2edea24). Report is 390 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/buffer.js 66.66% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #54588   +/-   ##
=======================================
  Coverage   87.32%   87.33%           
=======================================
  Files         649      649           
  Lines      182621   182632   +11     
  Branches    35042    35040    -2     
=======================================
+ Hits       159480   159498   +18     
- Misses      16397    16398    +1     
+ Partials     6744     6736    -8     
Files with missing lines Coverage Ξ”
lib/internal/buffer.js 97.41% <66.66%> (ΓΈ)

... and 30 files with indirect coverage changes

codecov[bot] avatar Aug 27 '24 11:08 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61732/

nodejs-github-bot avatar Aug 31 '24 06:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61737/

nodejs-github-bot avatar Aug 31 '24 12:08 nodejs-github-bot

PR is currently blocked from landing due to unreliable CI. Likely needs a rebase

jasnell avatar Sep 08 '24 03:09 jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/62167/

nodejs-github-bot avatar Sep 08 '24 09:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/62206/

nodejs-github-bot avatar Sep 09 '24 22:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/62749/

nodejs-github-bot avatar Sep 24 '24 20:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/62824/ πŸ’š

nodejs-github-bot avatar Sep 28 '24 13:09 nodejs-github-bot

Landed in 3800d60c661b

jasnell avatar Sep 28 '24 15:09 jasnell