node icon indicating copy to clipboard operation
node copied to clipboard

test: use `node:test` in `test-cli-syntax-bad`

Open avivkeller opened this issue 1 year ago • 1 comments
trafficstars

Now this test will output in the following format (via node:test). This can make debugging easier:

✔ Checking syntax for syntax/bad_syntax.js with -c (31.178327ms)
✔ Checking syntax for syntax/bad_syntax.js with --check (28.406593ms)
✔ Checking syntax for syntax/bad_syntax with -c (28.053855ms)
✔ Checking syntax for syntax/bad_syntax with --check (30.877816ms)
✔ Checking syntax for syntax/bad_syntax_shebang.js with -c (33.376369ms)
✔ Checking syntax for syntax/bad_syntax_shebang.js with --check (30.007192ms)
✔ Checking syntax for syntax/bad_syntax_shebang with -c (27.548402ms)
✔ Checking syntax for syntax/bad_syntax_shebang with --check (28.443502ms)

avivkeller avatar Aug 23 '24 00:08 avivkeller

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.61%. Comparing base (e70bd47) to head (a33839d). Report is 346 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54513      +/-   ##
==========================================
+ Coverage   87.34%   87.61%   +0.26%     
==========================================
  Files         649      650       +1     
  Lines      182524   182945     +421     
  Branches    35026    35395     +369     
==========================================
+ Hits       159420   160280     +860     
+ Misses      16373    15926     -447     
- Partials     6731     6739       +8     

see 124 files with indirect coverage changes

codecov[bot] avatar Aug 23 '24 02:08 codecov[bot]

It looks like there are CI failures.

cjihrig avatar Sep 05 '24 12:09 cjihrig

It looks like there are CI failures.

Not anymore :smiley:

avivkeller avatar Sep 07 '24 20:09 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/62119/

nodejs-github-bot avatar Sep 07 '24 22:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/62209/ 💛

nodejs-github-bot avatar Sep 09 '24 22:09 nodejs-github-bot

Landed in 5de919b6522d

jasnell avatar Sep 10 '24 15:09 jasnell