node icon indicating copy to clipboard operation
node copied to clipboard

test: refactor fs-watch tests due to macOS issue

Open santigimeno opened this issue 1 year ago • 4 comments

In macOS, fsevents generated immediately before start watching may leak into the event callback. See: https://github.com/nodejs/node/issues/54450 for an explanation. This might be fixed at some point in libuv though it may take some time (see: https://github.com/libuv/libuv/issues/3866). This commit comes in anticipation of the soon-to-be-released [email protected] which was making these tests very flaky.

santigimeno avatar Aug 22 '24 13:08 santigimeno

CI: https://ci.nodejs.org/job/node-test-pull-request/61350/

nodejs-github-bot avatar Aug 22 '24 15:08 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.33%. Comparing base (cc26951) to head (60e5173). Report is 149 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54498      +/-   ##
==========================================
- Coverage   87.34%   87.33%   -0.02%     
==========================================
  Files         649      649              
  Lines      182544   182524      -20     
  Branches    35030    35023       -7     
==========================================
- Hits       159445   159402      -43     
- Misses      16372    16385      +13     
- Partials     6727     6737      +10     

see 20 files with indirect coverage changes

codecov[bot] avatar Aug 22 '24 15:08 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61410/

nodejs-github-bot avatar Aug 24 '24 12:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61553/

nodejs-github-bot avatar Aug 27 '24 15:08 nodejs-github-bot

Landed in b345118e1e4960e8dcfa0dd5797f91dc4c4565e1

nodejs-github-bot avatar Sep 06 '24 17:09 nodejs-github-bot