node icon indicating copy to clipboard operation
node copied to clipboard

test: update wpt

Open avivkeller opened this issue 1 year ago • 9 comments

This PR updates the WPT files.

Note the following behavioral differences between Node.js and WPT:

test-structured-clone.js

Comparison: https://wpt.fyi/results/html/webappapis/structured-clone/structured-clone.any.html See: #55120

avivkeller avatar Aug 20 '24 22:08 avivkeller

Review requested:

  • [ ] @nodejs/web-standards

nodejs-github-bot avatar Aug 20 '24 22:08 nodejs-github-bot

This PR is a draft, and is no where near completion, but for record-keeping, this can't land until ~~#54468~~ https://github.com/nodejs/node/pull/54593 does.

avivkeller avatar Aug 27 '24 16:08 avivkeller

This PR is a draft, and is no where near completion, but for record-keeping, this can't land until #54468 does.

Not necessarily, just stay clear of updating WebCryptoAPI as that will be done separately in #54593

panva avatar Aug 27 '24 16:08 panva

Not necessarily, just stay clear of updating WebCryptoAPI as that will be done separately in #54593

Right, haha. I just to remove the WebCryptoAPI changes, and then fix the other failures...

avivkeller avatar Aug 27 '24 16:08 avivkeller

FWIW This is currently blocked by the followings issues attempting to bring Node.js up-to-specification: #54466 (and #54601) #54617 #54602 #54603

avivkeller avatar Aug 29 '24 16:08 avivkeller

If you've opened the specific issues for nonconform behaviours and can add them as a note to the expectation files then this is fine to proceed.

panva avatar Aug 29 '24 17:08 panva

Good to know. Thanks! I'll update this and proceed.

avivkeller avatar Aug 29 '24 17:08 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/62129/

nodejs-github-bot avatar Sep 07 '24 23:09 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.24%. Comparing base (bdddc04) to head (341b6c2). Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54468      +/-   ##
==========================================
- Coverage   88.25%   88.24%   -0.01%     
==========================================
  Files         651      651              
  Lines      183856   183856              
  Branches    35856    35853       -3     
==========================================
- Hits       162255   162252       -3     
+ Misses      14895    14883      -12     
- Partials     6706     6721      +15     

see 24 files with indirect coverage changes

codecov[bot] avatar Sep 25 '24 21:09 codecov[bot]

I'm closing this in favor of opening each update seperately, so some of them can be backported (if needed?)

avivkeller avatar Sep 30 '24 19:09 avivkeller