nodejs
Fix duplicated test descriptions
Some unit tests had duplicate names. Please review these small changes.
Thanks Christos
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.61%. Comparing base (
b4fd1fd) to head (b55ca4c). Report is 580 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #54140 +/- ##
==========================================
+ Coverage 87.06% 87.61% +0.54%
==========================================
Files 643 650 +7
Lines 181576 182834 +1258
Branches 34894 35383 +489
==========================================
+ Hits 158088 160183 +2095
+ Misses 16759 15924 -835
+ Partials 6729 6727 -2
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @unseen1980. Just want to let you know the first commit is authored by @ckoutsiaris (just making sure this is intentional). Additionally, could you remove the trailing .? Punctuation isn't supposed to be in commit messages.
Thank you!
Hey @unseen1980. Just want to let you know the first commit is authored by @ckoutsiaris (just making sure this is intentional). Additionally, could you remove the trailing
.? Punctuation isn't supposed to be in commit messages.Thank you!
Hi @RedYetiDev yes that is fine, same person :) I removed the . and I reset the commit history, please review again. Thank you 👍
Sorry I forgot to mention this earlier, but in order to land, the commit needs to be prefixed with a subsystem, followed by an active verb.
For example, test: remove ...
Commit Queue failed
- Loading data for nodejs/node/pull/54140 ✔ Done loading data for nodejs/node/pull/54140 ----------------------------------- PR info ------------------------------------ Title Fix duplicated test descriptions (#54140) Author Christos Koutsiaris <[email protected]> (@unseen1980, first-time contributor) Branch unseen1980:duplicated-test-names -> nodejs:main Labels test, author ready, needs-ci, commit-queue-squash, strip-types Commits 2 - test: remove duplicated test descriptions - fixup! test: remove duplicated test descriptions Committers 1 - Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54140 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54140 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 31 Jul 2024 11:00:48 GMT ✔ Approvals: 5 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/54140#pullrequestreview-2212768019 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54140#pullrequestreview-2231624173 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54140#pullrequestreview-2238513235 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54140#pullrequestreview-2258732846 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54140#pullrequestreview-2265320137 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-27T14:45:02Z: https://ci.nodejs.org/job/node-test-pull-request/61551/ - Querying data for job/node-test-pull-request/61551/ ✔ Last Jenkins CI successful ⚠ PR author is a new contributor: @unseen1980([email protected]) ⚠ - commit 4e93a87d4fef is authored by [email protected] -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10591774472
I think the issue is that the commit email does not match the account email:
commit 4e93a87d4fef is authored by [email protected]
@unseen1980
I think the issue is that the commit email does not match the account email:
commit 4e93a87d4fef is authored by [email protected]@unseen1980
Apologies for the mess, I just tried to amend the author of that commit. Not sure if it worked.
Can you squash commits into one and remove merge commits?
Hi @marco-ippolito it should be ok now, apologies for the messup. Thank you 👍
CONFLICT (content): Merge conflict in test/es-module/test-typescript-module.mjs. Let me rebase to fix that.
