node icon indicating copy to clipboard operation
node copied to clipboard

doc: add more details for localStorage and sessionStorage

Open Rekl0w opened this issue 1 year ago • 16 comments

doc: add more details for localStorage and sessionStorage

Releated #53871

Rekl0w avatar Jul 17 '24 08:07 Rekl0w

CC @cjihrig

avivkeller avatar Jul 17 '24 17:07 avivkeller

Please run make format-md when you get a change, It'll format the document.

avivkeller avatar Jul 18 '24 21:07 avivkeller

I use windows, i can get help for formatting.

Rekl0w avatar Jul 19 '24 08:07 Rekl0w

Any updates here ? @RedYetiDev

Rekl0w avatar Jul 22 '24 06:07 Rekl0w

I use windows, i can get help for formatting.

You can use vcbuild after installing the vcbuild lint command will work for you, if you encounter any problems, please feel free to write

in addition some information about windows is here: windows doc

mertcanaltin avatar Jul 25 '24 16:07 mertcanaltin

I used it but there are no changes in the files. @mertcanaltin

Rekl0w avatar Aug 12 '24 13:08 Rekl0w

I wonder if there is any warning message, what do you see as output

mertcanaltin avatar Aug 13 '24 14:08 mertcanaltin

There is no warning message. I also tried an extension called markdownlint on VS Code, no diff.

Rekl0w avatar Aug 13 '24 21:08 Rekl0w

I have made an arrangement for you in my local, you can update it from here https://github.com/mertcanaltin/node/commit/ff78d565de8b8e722d853ad4055a632e8c796b13

mertcanaltin avatar Aug 15 '24 10:08 mertcanaltin

Really appreciate that, thank you. @mertcanaltin

Rekl0w avatar Aug 15 '24 11:08 Rekl0w

Then it is up to you @cjihrig.

Rekl0w avatar Aug 19 '24 17:08 Rekl0w

There are a bunch of unrelated changes. Please revert those. I'll take a look at the changes relevant to web storage.

cjihrig avatar Aug 19 '24 17:08 cjihrig

node tools/lint-md/lint-md.mjs --format <insert file here> should help.

avivkeller avatar Aug 19 '24 17:08 avivkeller

Can you share the unreleated change commits ? @cjihrig

Rekl0w avatar Aug 19 '24 17:08 Rekl0w

Can you share the unreleated change commits ?

I'm not sure on the specific commits, but see all of the comments @RedYetiDev has left.

cjihrig avatar Aug 20 '24 11:08 cjihrig

I guess it is done now. @RedYetiDev @cjihrig

Rekl0w avatar Aug 23 '24 13:08 Rekl0w

Any updates here ?

Rekl0w avatar Sep 19 '24 10:09 Rekl0w

Landed in 99433a2d7a7a7d73588afbd22c82aa21d2db610a

nodejs-github-bot avatar Sep 20 '24 13:09 nodejs-github-bot