node icon indicating copy to clipboard operation
node copied to clipboard

doc: change backporting guide with updated info

Open avivkeller opened this issue 1 year ago • 1 comments

This PR updates the information in the backporting guide to (A) follow the Microsoft Style Guide, and (B) provide clearer instructions on how to backport.

avivkeller avatar Jul 06 '24 21:07 avivkeller

Review requested:

  • [ ] @nodejs/tsc

nodejs-github-bot avatar Jul 06 '24 21:07 nodejs-github-bot

This PR has an approval and no outstanding comments, WDYT about it?

avivkeller avatar Sep 10 '24 19:09 avivkeller

Can this land?

avivkeller avatar Sep 17 '24 22:09 avivkeller

Commit Queue failed
- Loading data for nodejs/node/pull/53746
✔  Done loading data for nodejs/node/pull/53746
----------------------------------- PR info ------------------------------------
Title      doc: change backporting guide with updated info (#53746)
Author     Aviv Keller <[email protected]> (@RedYetiDev)
Branch     RedYetiDev:patch-76 -> nodejs:main
Labels     doc, meta, commit-queue-squash
Commits    10
 - doc: change backporting guide with updated info
 - lint
 - Update backporting-to-release-lines.md
 - apply suggested changes
 - Update backporting-to-release-lines.md
 - Update backporting-to-release-lines.md
 - Update backporting-to-release-lines.md
 - Update backporting-to-release-lines.md
 - Update backporting-to-release-lines.md
 - Update backporting-to-release-lines.md
Committers 1
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/53746
Reviewed-By: Antoine du Hamel <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53746
Reviewed-By: Antoine du Hamel <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - Update backporting-to-release-lines.md
   ℹ  This PR was created on Sat, 06 Jul 2024 21:16:06 GMT
   ✔  Approvals: 1
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/53746#pullrequestreview-2174603580
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10917748812

nodejs-github-bot avatar Sep 18 '24 07:09 nodejs-github-bot

Landed in 5e87577b4f37911c2279176f183514d9496a1ceb

nodejs-github-bot avatar Sep 18 '24 07:09 nodejs-github-bot