node icon indicating copy to clipboard operation
node copied to clipboard

test: use correct file naming syntax for `util-parse-env`

Open avivkeller opened this issue 1 year ago • 14 comments

The project's test runner will only run files beginning with test-, so this PR fixes util-parse-env.js to test-util-parse-env.js.

avivkeller avatar Jul 02 '24 23:07 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/60062/

nodejs-github-bot avatar Jul 04 '24 10:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60237/

nodejs-github-bot avatar Jul 11 '24 02:07 nodejs-github-bot

Is this good to land?

avivkeller avatar Aug 06 '24 16:08 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/60913/

nodejs-github-bot avatar Aug 06 '24 16:08 nodejs-github-bot

Tests are failing :-/, CC @IlyasShabi

avivkeller avatar Aug 06 '24 17:08 avivkeller

The issue was that the fixture was updated in a different PR, leading this file to remain unupdated. It is now updated.

avivkeller avatar Aug 17 '24 23:08 avivkeller

If someone could start a CI, it would be appreciated?

avivkeller avatar Aug 17 '24 23:08 avivkeller

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.91%. Comparing base (e1e312d) to head (8589582). Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #53705      +/-   ##
==========================================
+ Coverage   87.90%   87.91%   +0.01%     
==========================================
  Files         651      651              
  Lines      183343   183343              
  Branches    35710    35712       +2     
==========================================
+ Hits       161165   161187      +22     
+ Misses      15466    15433      -33     
- Partials     6712     6723      +11     

see 39 files with indirect coverage changes

codecov[bot] avatar Aug 18 '24 00:08 codecov[bot]

(rebased main into the PR)

avivkeller avatar Aug 18 '24 15:08 avivkeller

Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/10444728825

github-actions[bot] avatar Aug 18 '24 23:08 github-actions[bot]

:sweat_smile: I always forget which different little peices cause the CI to fail to start...

avivkeller avatar Aug 18 '24 23:08 avivkeller

This should be good now that I've fixed the tests to account for the newer changes, could someone start a new CI to verify that?

avivkeller avatar Aug 23 '24 18:08 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/61388/

nodejs-github-bot avatar Aug 23 '24 18:08 nodejs-github-bot

CI is passing + many approving reviews, author ready for this to land?

avivkeller avatar Aug 26 '24 20:08 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/61970/

nodejs-github-bot avatar Sep 05 '24 08:09 nodejs-github-bot

There are 3 failing checks. Can you rebase and force push? We can't land a pull-request when existing CI is failing.

anonrig avatar Sep 08 '24 18:09 anonrig

CI: https://ci.nodejs.org/job/node-test-pull-request/62184/

nodejs-github-bot avatar Sep 08 '24 18:09 nodejs-github-bot

Rebased.

avivkeller avatar Sep 08 '24 19:09 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/62195/

nodejs-github-bot avatar Sep 09 '24 14:09 nodejs-github-bot

FWIW CI failures are flakes

avivkeller avatar Sep 12 '24 17:09 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/62406/

nodejs-github-bot avatar Sep 13 '24 15:09 nodejs-github-bot

Landed in b4088f5a5332d757bc2521600415747c2dd7f8f2

nodejs-github-bot avatar Sep 13 '24 18:09 nodejs-github-bot