test: use correct file naming syntax for `util-parse-env`
The project's test runner will only run files beginning with test-, so this PR fixes util-parse-env.js to test-util-parse-env.js.
CI: https://ci.nodejs.org/job/node-test-pull-request/60062/
CI: https://ci.nodejs.org/job/node-test-pull-request/60237/
Is this good to land?
CI: https://ci.nodejs.org/job/node-test-pull-request/60913/
Tests are failing :-/, CC @IlyasShabi
The issue was that the fixture was updated in a different PR, leading this file to remain unupdated. It is now updated.
If someone could start a CI, it would be appreciated?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.91%. Comparing base (
e1e312d) to head (8589582). Report is 49 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #53705 +/- ##
==========================================
+ Coverage 87.90% 87.91% +0.01%
==========================================
Files 651 651
Lines 183343 183343
Branches 35710 35712 +2
==========================================
+ Hits 161165 161187 +22
+ Misses 15466 15433 -33
- Partials 6712 6723 +11
(rebased main into the PR)
Failed to start CI
⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/10444728825
:sweat_smile: I always forget which different little peices cause the CI to fail to start...
This should be good now that I've fixed the tests to account for the newer changes, could someone start a new CI to verify that?
CI: https://ci.nodejs.org/job/node-test-pull-request/61388/
CI is passing + many approving reviews, author ready for this to land?
CI: https://ci.nodejs.org/job/node-test-pull-request/61970/
There are 3 failing checks. Can you rebase and force push? We can't land a pull-request when existing CI is failing.
CI: https://ci.nodejs.org/job/node-test-pull-request/62184/
Rebased.
CI: https://ci.nodejs.org/job/node-test-pull-request/62195/
FWIW CI failures are flakes
CI: https://ci.nodejs.org/job/node-test-pull-request/62406/
Landed in b4088f5a5332d757bc2521600415747c2dd7f8f2