node
node copied to clipboard
nodejs
http, readline: replace sort with toSorted
Just a minor chore, Richard's set.difference PR reminded me our V8 is new enough to support toSorted and we can avoid .slice().sort(...).
Failed to start CI
⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/9862771244
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Commit Queue failed
- Loading data for nodejs/node/pull/53623 ✔ Done loading data for nodejs/node/pull/53623 ----------------------------------- PR info ------------------------------------ Title http, readline: replace sort with toSorted (#53623) Author Benjamin Gruenbaum <[email protected]> (@benjamingr) Branch benjamingr:replace-with-tosorted -> nodejs:main Labels http, readline, needs-ci, typings, dont-land-on-v18.x, dont-land-on-v20.x Commits 1 - http, readline: replace sort with toSorted Committers 1 - Benjamin Gruenbaum <[email protected]> PR-URL: https://github.com/nodejs/node/pull/53623 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53623 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - http, readline: replace sort with toSorted ℹ This PR was created on Fri, 28 Jun 2024 12:38:56 GMT ✔ Approvals: 8 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53623#pullrequestreview-2148102817 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53623#pullrequestreview-2148120155 ✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/53623#pullrequestreview-2148213278 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53623#pullrequestreview-2148271807 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53623#pullrequestreview-2149963447 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53623#pullrequestreview-2149970876 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53623#pullrequestreview-2150175739 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53623#pullrequestreview-2151991049 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-07-09T23:43:34Z: https://ci.nodejs.org/job/node-test-pull-request/60208/ - Querying data for job/node-test-pull-request/60208/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9877917825