node icon indicating copy to clipboard operation
node copied to clipboard

timers: test timeout NaN warning in promises version

Open benjamingr opened this issue 1 year ago • 2 comments

Hey, https://github.com/nodejs/node/pull/46678 landed adding a warning when NaN is passed to timers. I noticed a test was missing for timers/promises there (the code works on both paths) - rather than holding that PR I figured we'd land it and I'd PR a test for timers/promises in a separate PR.

cc @jakecastelli

benjamingr avatar Jun 28 '24 12:06 benjamingr

weird the CI bot is not here yet 🤔

Edit: ah CI is in lockdown missed the PSA oops

debadree25 avatar Jun 28 '24 13:06 debadree25

The subsystem should be test: given it only touch the tests. Removed https://github.com/nodejs/node/labels/semver-major in favor of dont-land labels.

aduh95 avatar Jun 29 '24 09:06 aduh95

CI: https://ci.nodejs.org/job/node-test-pull-request/60042/

nodejs-github-bot avatar Jul 04 '24 01:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60503/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60504/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60505/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60506/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60508/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60507/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60509/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60511/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60510/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60512/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60513/

nodejs-github-bot avatar Jul 21 '24 22:07 nodejs-github-bot

Landed in 259163802c8ab2981da66f36b3c8fa43302869cf

aduh95 avatar Jul 22 '24 05:07 aduh95