node icon indicating copy to clipboard operation
node copied to clipboard

worker: allow copied NODE_OPTIONS in the env setting

Open joyeecheung opened this issue 8 months ago • 2 comments

When the worker spawning code copies NODE_OPTIONS from process.env, previously we do a check again on the copied NODE_OPTIONS and throw if it contains per-process settings. This can be problematic if the end user starts the process with a NODE_OPTIONS and the worker is spawned by a third-party that tries to extend process.env with some overrides before passing them into the worker. This patch adds another exception that skips the validation if the NODE_OPTIONS in the env setting is character-by-character equal to the parent NODE_OPTIONS. While some more intelligent filter can be useful too, this works good enough for the inheritance case, when the worker spawning code does not intend to modify NODE_OPTIONS.

Refs: https://github.com/nodejs/node/issues/41103

joyeecheung avatar Jun 26 '24 17:06 joyeecheung