module: improve error message for cjs code in an esm module
Fixes: https://github.com/nodejs/node/issues/40544
Review requested:
- [ ] @nodejs/loaders
Can you please show the before and after?
Can you please show the before and after?
Sorry, do you mean you want to see a screenshot of this printed on the console?
Please provide example code that triggers the error. Copy/paste the error that results from current Node and on your branch.
@GeoffreyBooth Thanks for clarifying. It may take me a few days, but I'll do that soon.
Can you please address the failure in es-module/test-esm-undefined-cjs-global-like-variables?
Hi @DanKaplanSES given the lack of reply to the last comment and the fact that this PR has been inactive for roughly a year I am adding a stalled label to it so that it can be cleaned up (as per the nodejs policy).
If you intend to finish working on this please do let me know and I will remove the label :slightly_smiling_face:
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.