node icon indicating copy to clipboard operation
node copied to clipboard

module: improve error message for cjs code in an esm module

Open DanKaplanSES opened this issue 1 year ago • 8 comments

Fixes: https://github.com/nodejs/node/issues/40544

DanKaplanSES avatar May 25 '24 21:05 DanKaplanSES

Review requested:

  • [ ] @nodejs/loaders

nodejs-github-bot avatar May 25 '24 21:05 nodejs-github-bot

Can you please show the before and after?

GeoffreyBooth avatar May 26 '24 03:05 GeoffreyBooth

Can you please show the before and after?

Sorry, do you mean you want to see a screenshot of this printed on the console?

DanKaplanSES avatar May 26 '24 18:05 DanKaplanSES

Please provide example code that triggers the error. Copy/paste the error that results from current Node and on your branch.

GeoffreyBooth avatar May 26 '24 19:05 GeoffreyBooth

@GeoffreyBooth Thanks for clarifying. It may take me a few days, but I'll do that soon.

DanKaplanSES avatar May 26 '24 20:05 DanKaplanSES

Can you please address the failure in es-module/test-esm-undefined-cjs-global-like-variables?

aduh95 avatar Jun 13 '24 21:06 aduh95

Hi @DanKaplanSES given the lack of reply to the last comment and the fact that this PR has been inactive for roughly a year I am adding a stalled label to it so that it can be cleaned up (as per the nodejs policy).

If you intend to finish working on this please do let me know and I will remove the label :slightly_smiling_face:

dario-piotrowicz avatar Jun 11 '25 21:06 dario-piotrowicz

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

github-actions[bot] avatar Jun 11 '25 21:06 github-actions[bot]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

github-actions[bot] avatar Jul 12 '25 00:07 github-actions[bot]