node icon indicating copy to clipboard operation
node copied to clipboard
verified publisher icon nodejs

deps: enable unbundling of simdjson, simdutf, ada

Open lemire opened this issue 1 year ago • 6 comments

When building Node.js, it is possible to replace most dependencies by locally provided ones. However, it does not apply for at least three dependencies: simdjson, simdutf, ada. This PR seeks to enable this possibility.

Fixes https://github.com/nodejs/node/issues/52914

lemire avatar May 09 '24 19:05 lemire

cc @williamh

lemire avatar May 09 '24 19:05 lemire

cc @nodejs/build @richardlau

anonrig avatar May 09 '24 19:05 anonrig

Is it possible to add ngtcp2 to this pr, or should that be done in another pr? Thanks much

williamh avatar May 09 '24 20:05 williamh

@williamh My reading of the code is that ngtcp2 can be made unbundled right now. But gentoo does not choose to do so. I think @jasnell did add this feature already.

lemire avatar May 09 '24 20:05 lemire

Ok, thanks for this info, I'll take a look at my side again.

williamh avatar May 09 '24 20:05 williamh

CI: https://ci.nodejs.org/job/node-test-pull-request/59068/

nodejs-github-bot avatar May 09 '24 21:05 nodejs-github-bot

Landed in d78537b3dfb6a7ca1b2f0687e0fbfbd631cb5537

nodejs-github-bot avatar May 11 '24 19:05 nodejs-github-bot