node
node copied to clipboard
assert: --assert-full-diff
Fixes #51902
This PR adds a --assert-full-diff
option to have AssertionErrors print the full diff, rather than a truncated version.
i'd rather we add an options object to assert.deepStrictEqual
and assert.strictEqual
instead of a flag
i'd rather we add an options object to
assert.deepStrictEqual
andassert.strictEqual
instead of a flag
I'm worried that users may misunderstand the options object for an object to be asserted
The commit message does not adhere to the guidelines, the tests are not passing: I'm converting this PR to draft. I think you can that reviewing PRs takes time, and as it is currently it doesn't seem like reviewing this PR would be a good use of my time. Have in mind that adding a CLI flag is a higher bar than extending the API.
Sorry if my comment sounds dismissive, I know you spent time making this PR, and I would prefer show more respect of that time you spend, but honestly I don't feel that you sending this PR as is is very respectful of the reviewers' time either.
The commit message does not adhere to the guidelines, the tests are not passing: I'm converting this PR to draft. I think you can that reviewing PRs takes time, and as it is currently it doesn't seem like reviewing this PR would be a good use of my time. Have in mind that adding a CLI flag is a higher bar than extending the API.
No problem! I'll fix the PR and verify everything before I resubmit
Sorry if my comment sounds dismissive, I know you spent time making this PR, and I would prefer show more respect of that time you spend, but honestly I don't feel that you sending this PR as is is very respectful of the reviewers' time either.
I'm sorry, I'll fix the PR, I didn't realize it was failing the tests (sorry!).
(forgot to un-draft this)
Note: The tests are passing
Can this land (once conflicts are resolved), or is it not even worth it?