node icon indicating copy to clipboard operation
node copied to clipboard

build: exit on unsupported host OS for Android

Open VoltrexKeyva opened this issue 1 year ago • 2 comments
trafficstars

The Android configure script throws an unhelpful error message telling the user that toolchain_path is not defined when the script is run on an unsupported host OS, exit with a more helpful message instead while listing the supported host OSes.

VoltrexKeyva avatar May 08 '24 00:05 VoltrexKeyva

Wouldn't it be better to fix it here https://github.com/nodejs/node/blob/cbd6ddbb4a40b8d604ed7a1990f7133ae518fd41/android_configure.py#L13-L15

lpinca avatar May 11 '24 19:05 lpinca

I assume this doesn't need a Jenkins CI right?

VoltrexKeyva avatar May 22 '24 05:05 VoltrexKeyva

Landed in 0cbbab9a4d6a11c1fc219acfad54f05f51fec17b

nodejs-github-bot avatar May 25 '24 07:05 nodejs-github-bot