node
node copied to clipboard
build: exit on unsupported host OS for Android
trafficstars
The Android configure script throws an unhelpful error message telling the user that toolchain_path is not defined when the script is run on an unsupported host OS, exit with a more helpful message instead while listing the supported host OSes.
Wouldn't it be better to fix it here https://github.com/nodejs/node/blob/cbd6ddbb4a40b8d604ed7a1990f7133ae518fd41/android_configure.py#L13-L15
I assume this doesn't need a Jenkins CI right?
Landed in 0cbbab9a4d6a11c1fc219acfad54f05f51fec17b