node icon indicating copy to clipboard operation
node copied to clipboard

meta: add module label for the lib/internal/modules folder

Open redyetidev opened this issue 9 months ago • 2 comments

This PR updates the lib/internal/modules folder to use the module label

redyetidev avatar May 06 '24 15:05 redyetidev

Fast-track has been requested by @RedYetiDev. Please 👍 to approve.

github-actions[bot] avatar May 06 '24 15:05 github-actions[bot]

Fast-Tracking as this is not a major change, but rather a slight label adjustment

redyetidev avatar May 06 '24 15:05 redyetidev

This hasn't seen any objections, is it good to land?

redyetidev avatar Aug 06 '24 15:08 redyetidev

Commit Queue failed
- Loading data for nodejs/node/pull/52858
✔  Done loading data for nodejs/node/pull/52858
----------------------------------- PR info ------------------------------------
Title      meta: add module label for the lib/internal/modules folder (#52858)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     RedYetiDev:patch-15 -> nodejs:main
Labels     module, meta
Commits    2
 - meta: add module label for the lib/internal/modules folder
 - Update label-pr-config.yml
Committers 1
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/52858
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52858
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 06 May 2024 15:19:36 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52858#pullrequestreview-2051247449
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52858
From https://github.com/nodejs/node
 * branch                  refs/pull/52858/merge -> FETCH_HEAD
✔  Fetched commits as 3660ad5c9234..f0b0c4293bb2
--------------------------------------------------------------------------------
Auto-merging .github/label-pr-config.yml
[main ee854f7680] meta: add module label for the lib/internal/modules folder
 Author: Aviv Keller <[email protected]>
 Date: Mon May 6 11:19:07 2024 -0400
 1 file changed, 1 insertion(+)
Auto-merging .github/label-pr-config.yml
[main 40522e3d42] Update label-pr-config.yml
 Author: Aviv Keller <[email protected]>
 Date: Mon May 6 11:20:02 2024 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- meta: add module label for the lib/internal/modules folder

PR-URL: https://github.com/nodejs/node/pull/52858 Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD de8f2d53b6] meta: add module label for the lib/internal/modules folder Author: Aviv Keller <[email protected]> Date: Mon May 6 11:19:07 2024 -0400 1 file changed, 1 insertion(+) Rebasing (3/4) Rebasing (4/4)

Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- Update label-pr-config.yml

PR-URL: https://github.com/nodejs/node/pull/52858 Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD 8cfc905515] Update label-pr-config.yml Author: Aviv Keller <[email protected]> Date: Mon May 6 11:20:02 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/10271857199

nodejs-github-bot avatar Aug 06 '24 18:08 nodejs-github-bot

Landed in dc86592f20a463f41dc94dec3d8f7f5e3a6238d9

nodejs-github-bot avatar Aug 06 '24 18:08 nodejs-github-bot