node icon indicating copy to clipboard operation
node copied to clipboard

doc: document watermark string behavior

Open benjamingr opened this issue 9 months ago • 2 comments

Bikeshedding/doc suggestions (should we edit it in other places like (readableLength/writableLength?) welcome

ping @lpinca @nodejs/streams


Documents that we calculate the highWaterMark value of streams operating on strings using the number of UTF-16 code units.

Fixes: https://github.com/nodejs/node/issues/52818

benjamingr avatar May 05 '24 13:05 benjamingr

I'm not sure if the "but not decoding" bit is sufficient, it might be a bit too generic for someone not familiar with the implementation, but I can't think of anything better to suggest.

lpinca avatar May 05 '24 13:05 lpinca

(3[+1] approving reviews; no failed tests)

redyetidev avatar May 07 '24 16:05 redyetidev

Landed in 761d2ce43cc5c996f4bdc5b873384eb4f2346488

aduh95 avatar May 10 '24 17:05 aduh95