node icon indicating copy to clipboard operation
node copied to clipboard

lib: do not call callback if socket is closed

Open theanarkh opened this issue 10 months ago • 2 comments

Do not call callback if socket is closed.

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

theanarkh avatar May 04 '24 07:05 theanarkh

Review requested:

  • [ ] @nodejs/net

nodejs-github-bot avatar May 04 '24 07:05 nodejs-github-bot

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/8949880553

github-actions[bot] avatar May 04 '24 10:05 github-actions[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59279/

nodejs-github-bot avatar May 18 '24 05:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59282/

nodejs-github-bot avatar May 18 '24 07:05 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/52829
✔  Done loading data for nodejs/node/pull/52829
----------------------------------- PR info ------------------------------------
Title      dgram: do not call callback if socket is closed (#52829)
Author     theanarkh  (@theanarkh)
Branch     theanarkh:dont-emit-error-after-close-handle -> nodejs:main
Labels     dgram, needs-ci
Commits    1
 - lib: do not call callback if socket is closed
Committers 1
 - theanarkh 
PR-URL: https://github.com/nodejs/node/pull/52829
Reviewed-By: Matteo Collina 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52829
Reviewed-By: Matteo Collina 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - lib: do not call callback if socket is closed
   ℹ  This PR was created on Sat, 04 May 2024 07:58:48 GMT
   ✔  Approvals: 1
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52829#pullrequestreview-2057177270
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-05-18T07:21:46Z: https://ci.nodejs.org/job/node-test-pull-request/59282/
- Querying data for job/node-test-pull-request/59282/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9146455101

nodejs-github-bot avatar May 19 '24 09:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59301/

nodejs-github-bot avatar May 19 '24 10:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59302/

nodejs-github-bot avatar May 19 '24 15:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59308/

nodejs-github-bot avatar May 20 '24 02:05 nodejs-github-bot

Landed in f05baff6ade84d9e7f66c9d3f425c117dc161756

nodejs-github-bot avatar May 23 '24 20:05 nodejs-github-bot