node
node copied to clipboard
lib: do not call callback if socket is closed
Do not call callback if socket is closed.
- [x]
make -j4 test
(UNIX), orvcbuild test
(Windows) passes - [x] tests and/or benchmarks are included
- [x] documentation is changed or added
- [x] commit message follows commit guidelines
Review requested:
- [ ] @nodejs/net
Failed to start CI
⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/8949880553
CI: https://ci.nodejs.org/job/node-test-pull-request/59279/
CI: https://ci.nodejs.org/job/node-test-pull-request/59282/
Commit Queue failed
- Loading data for nodejs/node/pull/52829 ✔ Done loading data for nodejs/node/pull/52829 ----------------------------------- PR info ------------------------------------ Title dgram: do not call callback if socket is closed (#52829) Author theanarkhhttps://github.com/nodejs/node/actions/runs/9146455101(@theanarkh) Branch theanarkh:dont-emit-error-after-close-handle -> nodejs:main Labels dgram, needs-ci Commits 1 - lib: do not call callback if socket is closed Committers 1 - theanarkh PR-URL: https://github.com/nodejs/node/pull/52829 Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52829 Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - lib: do not call callback if socket is closed ℹ This PR was created on Sat, 04 May 2024 07:58:48 GMT ✔ Approvals: 1 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52829#pullrequestreview-2057177270 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-18T07:21:46Z: https://ci.nodejs.org/job/node-test-pull-request/59282/ - Querying data for job/node-test-pull-request/59282/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
CI: https://ci.nodejs.org/job/node-test-pull-request/59301/
CI: https://ci.nodejs.org/job/node-test-pull-request/59302/
CI: https://ci.nodejs.org/job/node-test-pull-request/59308/
Landed in f05baff6ade84d9e7f66c9d3f425c117dc161756